Feeling Lucky
?
[#27797] - [4.0] Fix edge case PHP Notice in com_finder
- Fixed in Code Base
- 4 Feb 2020
- Medium
- Build: 4.0-dev
- # 27797
- Diff
- wilsonge:patch-finder
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Fixes an edge case in com_finder which gave a PHP Notice
Testing Instructions
Create a category in Joomla such as "Article 0 of 1" and save it. Then check your PHP error log (note due to the redirect to the list view you won't see this in the UI) and you'll find a PHP Notice. Apply patch. After patch the notice is gone.
Alternatively you can code review array_filter PHP documentation which tells you array keys are preserved. Which is bad for our for loop later on line 131 here 4.0-dev...wilsonge:patch-finderdiff-6f122d9d8749e848d0ea1343cf256cd1L131.
Documentation Changes Required
None
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
Hackwar
- comment
- 4 Feb 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27797.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 4 Feb 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27797.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-04 14:08:52 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 4 Feb 2020
Thanks guys!
I have tested this item✅ successfully on 43ae611
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27797.