[#27793] - [4.0] Atum top
- Fixed in Code Base
- 6 Feb 2020
- Medium
- Build: staging
- # 27793
- Diff
- ceford:atum-top
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27791
Summary of Changes
Added customtop jdoc position to atum template.
Testing Instructions
Obtain test top menu module: https://github.com/ceford/j4xdemos-admin-mod-topmenu/blob/master/mod_topmenu.zip
Install / enable / assign to customtop position
Expected result
a top menu appears as well as the standard side menu
disable when finished
Actual result
Works for me
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration |
| Category | Unit Tests Repository Administration | ⇒ | Administration Templates (admin) |
Quy
- | Title |
|
||||||
| Category | Administration Templates (admin) | ⇒ | Administration Language & Strings Templates (admin) |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
Why is it named “customtop” and not just e.g. “topmenu”?
richard67: Why is it named “customtop”
I thought it best not to imply that this is an alternative menu position for the standard menu. And it may have other uses. For example I often use a custom html module site notice 'this site is closing...'.
Can be useful indeed.
I'm happy to merge this. I'm just adding here for future people seeing this. Just because this position exists doesn't mean we support a top menu. It means the position exists for people to use for whatever they want - if you choose to put a top menu there it's at your own risk ;)
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-06 21:47:56 |
| Closed_By | ⇒ | wilsonge |
Thanks!
Makes sense to me now, custom top, after the explanations above.
Please look at https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/language/en-GB/tpl_atum.sys.ini and update this PR accordingly