User tests: Successful: Unsuccessful:
The admin menu module has options to show/hide the "add new" shortcuts on the menu. This option was not working. It is now
Partial Pull Request for Issue #26050
Category | ⇒ | Modules Administration |
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Just to confirm something can you go to the module and save it - even without changing any settings
After saving, they appear. So the value initially is a string and after saving is an integer.
I thought that was the case. The problem is not here with this code. It is a much bigger problem with the installation sql having the wrong values - and not just for this field
Is there already an issue or PR for the wrong SQL? Can’t look now, am posting on mobile and will go offline for sleep soon.
I have tested this item
This works fine and is basically a no-brainer.
The parameter currently isn't used and this PR adds the corresponding code for it.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
This PR will not display the shortcut icon until Admin Menu
module is updated.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-11 07:11:50 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
|
On a clean install of your branch, the shortcuts do not appear even though
Add New Shortcuts
setting isShow
.