? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
3 Feb 2020

The admin menu module has options to show/hide the "add new" shortcuts on the menu. This option was not working. It is now

Partial Pull Request for Issue #26050

image

avatar joomla-cms-bot joomla-cms-bot - change - 3 Feb 2020
Category Modules Administration
avatar brianteeman brianteeman - open - 3 Feb 2020
avatar brianteeman brianteeman - change - 3 Feb 2020
Status New Pending
avatar brianteeman brianteeman - change - 3 Feb 2020
Labels Added: ?
avatar Quy
Quy - comment - 3 Feb 2020

On a clean install of your branch, the shortcuts do not appear even though Add New Shortcuts setting is Show.

avatar brianteeman
brianteeman - comment - 3 Feb 2020

Just to confirm something can you go to the module and save it - even without changing any settings

avatar Quy
Quy - comment - 3 Feb 2020

After saving, they appear. So the value initially is a string and after saving is an integer.

avatar brianteeman
brianteeman - comment - 3 Feb 2020

I thought that was the case. The problem is not here with this code. It is a much bigger problem with the installation sql having the wrong values - and not just for this field

avatar richard67
richard67 - comment - 6 Feb 2020

Is there already an issue or PR for the wrong SQL? Can’t look now, am posting on mobile and will go offline for sleep soon.

avatar Bakual Bakual - test_item - 10 Feb 2020 - Tested successfully
avatar Bakual
Bakual - comment - 10 Feb 2020

I have tested this item successfully on 8a9e9ec

This works fine and is basically a no-brainer.

The parameter currently isn't used and this PR adds the corresponding code for it.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27788.

avatar jwaisner jwaisner - test_item - 10 Feb 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 10 Feb 2020

I have tested this item successfully on 8a9e9ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27788.

avatar jwaisner jwaisner - change - 10 Feb 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 10 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27788.

avatar Quy
Quy - comment - 10 Feb 2020

This PR will not display the shortcut icon until Admin Menu module is updated.

avatar rdeutz rdeutz - change - 11 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-11 07:11:50
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 11 Feb 2020
avatar rdeutz rdeutz - merge - 11 Feb 2020

Add a Comment

Login with GitHub to post a comment