? ?

Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
2 Feb 2020

Pull Request for Issue #27772

Should I close the issue #27772 ? I am not sure whether changes in J4 will be adopted because the directory is now moved.

avatar joomla-cms-bot joomla-cms-bot - change - 2 Feb 2020
Category Front End com_contact
avatar astridx astridx - open - 2 Feb 2020
avatar astridx astridx - change - 2 Feb 2020
Status New Pending
avatar wilsonge
wilsonge - comment - 2 Feb 2020

The changes will get ported from here anyhow :) it’s just a bit of extra work on my end

avatar toivo toivo - test_item - 4 Feb 2020 - Tested successfully
avatar toivo
toivo - comment - 4 Feb 2020

I have tested this item successfully on 82c10b4

Tested in 3.9.15 and PHP 7.4.2 on localhost


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27775.

avatar Quy Quy - test_item - 4 Feb 2020 - Tested successfully
avatar Quy
Quy - comment - 4 Feb 2020

I have tested this item successfully on 82c10b4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27775.

avatar Quy Quy - change - 4 Feb 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 4 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27775.

avatar astridx astridx - change - 4 Feb 2020
Labels Added: ?
avatar astridx
astridx - comment - 4 Feb 2020

I honestly don't know what the import jimport('joomla.html.html.bootstrap'); is for.

Since the file /libraries/src/HTML/HTML/Bootstrap does not exist, I dare to delete this line, as asked here.

avatar brianteeman
brianteeman - comment - 4 Feb 2020

that line originates from #29072 - you can find out why it existed there

avatar astridx
astridx - comment - 4 Feb 2020

Thank you @brianteeman But, what is #29072? Currently our highest number is #27805.

avatar brianteeman
brianteeman - comment - 4 Feb 2020

Sorry thats an old joomlacode reference number
https://developer.joomla.org/joomlacode-archive/issue-29072.html

avatar rdeutz rdeutz - change - 5 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-05 17:50:56
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 5 Feb 2020
avatar rdeutz rdeutz - merge - 5 Feb 2020

Add a Comment

Login with GitHub to post a comment