Feeling Lucky
?
[#27770] - [4.0] RFC component icons
- Closed
- 2 Feb 2020
- Medium
- Build: staging
- # 27770
In the dashboards of joomla 4 we have a situation where sometimes there is an icon and sometimes not.
components dashboard - no icons
users dashboard - has icons
The reason for this is that the components dashboard is dynamically created while the others are statically defined (with an icon)
joomla-cms/administrator/components/com_menus/presets/users.xml
Lines 37 to 41 in 118d4c0
This can be resolved by updating the sql so that the params field in the menus table includes for example.
"menu_icon":"fa fa-puzzle-piece",
The alternate menu already uses this param
Thoughts? Backwards Compatibility issues? Extension issues?
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- comment
- 2 Feb 2020
I have the icons working now - will submit the pr after the rugby ;)
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-02 17:09:03 |
| Closed_By | ⇒ | brianteeman |
I guess that works, and if it's in the SQL, then we can also remove the hardcoding.
Just needs also a way for 3rd party to populate those menu params, which currently imho doesn't work. But that should be doable I guess.