?
avatar Bakual
Bakual
1 Feb 2020

The icons used for a 3rd party extension dashboard titles are created from a language string.

There was an original issue opened for core (#26217) which got fixed by adding special threatment for core (#26252).
While that worked obviously, it's wrong from an architecture point of view and doesn't work for 3rd parties, which still would have to add CSS classes to a language string.
Also the code would only load a 3rd party provied string if the "dashboard" parameter has a section (eg com_foo.bar), which is wrong as well.

Expected result

Icon is defined by the respective component by an XML definition or PHP code.

Actual result

Component (content, menu, users, ...) specific stuff is hardcoded into com_cpanel.

Additional comments

I stumbled over this by reverse engineering the dashboard functionality so I could add that to my component.
In that view there is way to much special handling for core components which must be eliminated so it is easier for 3rd parties to figure out how something works (since there likely will be no documentation).

avatar Bakual Bakual - open - 1 Feb 2020
avatar joomla-cms-bot joomla-cms-bot - change - 1 Feb 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 1 Feb 2020
avatar richard67
richard67 - comment - 1 Feb 2020

@wilsonge Do you think this is a release blocker? Or even a beta blocker?

avatar brianteeman
brianteeman - comment - 2 Feb 2020

@Bakual just seen this after writing my own post #27770

avatar Bakual
Bakual - comment - 2 Feb 2020

Since Brian is a step further already, I'm closing this one in favor of his issue.

avatar Bakual Bakual - change - 2 Feb 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-02-02 12:12:51
Closed_By Bakual
avatar Bakual Bakual - close - 2 Feb 2020
avatar brianteeman
brianteeman - comment - 2 Feb 2020

see #27773

Add a Comment

Login with GitHub to post a comment