? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
31 Jan 2020

This PR adds two filters to the list of reports, Client and Directive.

To test go to the CSP component (it's on the system dashboard) and in the component options set the mode to detect

After you have browsed a few pages on the site and the admin return to the CSP component and you should have a list of reports.

You can now test the two new filters.

@SharkyKZ I would really appreciate your review of the queries as I am still learning the prepared stuff.

@zero-24 I hope this is OK with you. I wasn't sure about also adding a blocked element filter. Not sure how useful that would be - your thoughts?

image

avatar brianteeman brianteeman - open - 31 Jan 2020
avatar brianteeman brianteeman - change - 31 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jan 2020
Category Administration com_csp Language & Strings
avatar brianteeman brianteeman - change - 31 Jan 2020
Labels Added: ? ?
avatar richard67 richard67 - test_item - 1 Feb 2020 - Tested successfully
avatar richard67
richard67 - comment - 1 Feb 2020

I have tested this item successfully on fad8015


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27738.

avatar jwaisner jwaisner - test_item - 1 Feb 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 1 Feb 2020

I have tested this item successfully on fad8015


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27738.

avatar richard67 richard67 - change - 1 Feb 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 1 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27738.

avatar rdeutz rdeutz - change - 2 Feb 2020
Labels Added: ?
avatar rdeutz rdeutz - change - 3 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-03 12:55:06
Closed_By rdeutz
avatar rdeutz rdeutz - close - 3 Feb 2020
avatar rdeutz rdeutz - merge - 3 Feb 2020
avatar brianteeman
brianteeman - comment - 3 Feb 2020

Thanks. @zero-24 I would still like your feedback on the original question please.

avatar zero-24
zero-24 - comment - 3 Feb 2020

@zero-24 I hope this is OK with you. I wasn't sure about also adding a blocked element filter. Not sure how useful that would be - your thoughts?

Sorry for the late reply 3 days is quite fast :D

Thanks for the addition it looks good to me. As for the blocked element i would say we can leave it off now ideally every combination is unique anyway. When we need it later it would not be complicated to add it too.

avatar brianteeman
brianteeman - comment - 3 Feb 2020

Glad you agree

Add a Comment

Login with GitHub to post a comment