? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
30 Jan 2020

Pull Request for new issue.

Summary of Changes

This Pull Request (PR) corrects the ordering of the fields for database connection encryption options in the installation form so it is the same as in the server tab of global configuration in backend when value"Two-way authentication" is selected in drop down "Connection Encryption". For the other values "Default (server controlled)" and "One-way authentication" of this drop down ordering is already ok.

The reason for the wrong ordering is a mistake I've made in my PR #27348 .

The form xml file https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/forms/setup.xml already has the right ordering, but the installation form doesn't use the xml to create the fields.

Testing Instructions

  1. On an installed 4.0-dev or recent nightly build, login to backend and go to the "Server" tab of "Global Configuration".
  2. Select option "Two-way authentication" in the drop down "Connection Encryption".
  3. Note the order of the fields for database encryption e.g. by making a screenshot.
  4. Set the switcher "Server Certificate Verification" to "Yes".
  5. Note again the order of the fields for database encryption e.g. by making a screenshot.
  6. Start a new installation of the same 4.0-dev code or nightly build package on another server, or use the same server and delete configuration.php before starting the installation.
  7. When coming to the databae connection options, select option "Two-way authentication" in the drop down "Connection Encryption".
  8. Note the order of the fields for database encryption e.g. by making a screenshot.
  9. Set the switcher "Server Certificate Verification" to "Yes".
  10. Note again the order of the fields for database encryption e.g. by making a screenshot.
  11. Compare the results from global configuration and the installation form.
    Result: See section "Actual result" below.
  12. Apply this PR.
  13. Repeat steps 6 to 11.
    Result: See section "Expected result" below.

Expected result

The ordering of fields for database connection encryption options is the same as in global configuration in backend.

  • 2-way authentication without server certificate verification:
    db-ssl-options_install_2-way-no-verify_corrected
  • 2-way authentication with server certificate verification:
    db-ssl-options_install_2-way-verify_corrected

Actual result

  • 2-way authentication without server certificate verification:
    db-ssl-options_install_2-way-no-verify
  • 2-way authentication with server certificate verification:
    db-ssl-options_install_2-way-verify

Documentation Changes Required

No. Help screens for installation form have to be updated anyway.

avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2020
Category Installation
avatar richard67 richard67 - open - 30 Jan 2020
avatar richard67 richard67 - change - 30 Jan 2020
Status New Pending
avatar richard67 richard67 - change - 30 Jan 2020
Labels Added: ?
avatar richard67 richard67 - change - 30 Jan 2020
The description was changed
avatar richard67 richard67 - edited - 30 Jan 2020
avatar richard67 richard67 - change - 30 Jan 2020
The description was changed
avatar richard67 richard67 - edited - 30 Jan 2020
avatar richard67 richard67 - change - 30 Jan 2020
The description was changed
avatar richard67 richard67 - edited - 30 Jan 2020
avatar Quy Quy - test_item - 30 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 30 Jan 2020

I have tested this item successfully on fa252d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27727.

avatar SharkyKZ SharkyKZ - test_item - 30 Jan 2020 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 30 Jan 2020

I have tested this item successfully on fa252d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27727.

avatar SharkyKZ SharkyKZ - change - 30 Jan 2020
Status Pending Ready to Commit
avatar SharkyKZ
SharkyKZ - comment - 30 Jan 2020

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27727.

avatar richard67
richard67 - comment - 30 Jan 2020

Thanks for testing.

avatar Quy Quy - change - 31 Jan 2020
Labels Added: ?
avatar Quy Quy - change - 31 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-31 15:47:35
Closed_By Quy
avatar Quy Quy - close - 31 Jan 2020
avatar Quy Quy - merge - 31 Jan 2020
avatar richard67
richard67 - comment - 31 Jan 2020

Thanks.

Add a Comment

Login with GitHub to post a comment