[#27725] - Grid boolean
- Closed
- 20 Mar 2022
- Medium
- Build: staging
- # 27725
- Diff
- softarius:grid_boolean
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27724.
Summary of Changes
Class JHtmlGrid is modified.
Testing Instructions
Add to any grid admin layout using JHTML like this
JHTML::_('grid.boolean', $i, $row->important,'helloworlds.important','helloworlds.unimportant');
Example -
Joomla-3-Hello-World-Component_0.16.zip
Expected result
The row is selected and the task is invoked
Actual result
Error JSON.decode is not a function into JavaScript console
Documentation Changes Required
Nothing
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
@softarius Expected result and actual result in your PR description is the same. Can it be a copy paste mistake? In the issue its different.
I was thinking to describe actual result after the fix in PR.
However, in the issue, I describe the actual result before the fix.
Whats is right?
Actual result = current Joomla code = without this PR, Expected result = how it should be = with this PR (if PR does what it shall do)
Now description is correct.
Actual result = current Joomla code = without this PR, Expected result = how it should be = with this PR (if PR does what it shall do)
Thanks. I see.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
I think the intention here was to use JSON.parse().
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-20 14:13:09 |
| Closed_By | ⇒ | softarius | |
| Labels |
Added:
?
Removed: ? |
||
@softarius Expected result and actual result in your PR description is the same. Can it be a copy paste mistake? In the issue its different.