? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
30 Jan 2020

Summary of Changes

Default values for 3-5 arguments of Joomla\CMS\Language\Language::load() are null, false, true.

public function load($extension = 'joomla', $basePath = JPATH_BASE, $lang = null, $reload = false, $default = true)

We can omit them when making the calls.

Testing Instructions

Code review.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 30 Jan 2020
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2020
Category Administration com_admin com_categories com_config com_content com_contenthistory com_cpanel com_fields com_finder com_installer com_joomlaupdate com_login com_menus com_modules
avatar SharkyKZ SharkyKZ - change - 30 Jan 2020
Status New Pending
avatar Quy Quy - test_item - 30 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 30 Jan 2020

I have tested this item successfully on 10b5a64


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27720.

avatar richard67 richard67 - test_item - 2 Feb 2020 - Tested successfully
avatar richard67
richard67 - comment - 2 Feb 2020

I have tested this item successfully on 10b5a64


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27720.

avatar richard67 richard67 - change - 2 Feb 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 2 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27720.

avatar richard67 richard67 - change - 2 Feb 2020
Labels Added: ? ?
avatar richard67
richard67 - comment - 2 Feb 2020

@SharkyKZ Drone failure seems not to be related to this PR, but if you wanna be sure: Use the update to base branch button ;-)

avatar SharkyKZ SharkyKZ - change - 2 Feb 2020
Labels
avatar rdeutz rdeutz - change - 2 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-02 15:09:11
Closed_By rdeutz
avatar rdeutz rdeutz - close - 2 Feb 2020
avatar rdeutz rdeutz - merge - 2 Feb 2020

Add a Comment

Login with GitHub to post a comment