? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
30 Jan 2020

Summary of Changes

Removes import pointing to non-existing file in favor of namespaced class.

Testing Instructions

Code review is fine.

Documentation Changes Required

No.

avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2020
Category Front End Plugins
avatar SharkyKZ SharkyKZ - open - 30 Jan 2020
avatar SharkyKZ SharkyKZ - change - 30 Jan 2020
Status New Pending
avatar SharkyKZ SharkyKZ - change - 31 Jan 2020
Labels Added: ?
avatar Quy Quy - test_item - 31 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 31 Jan 2020

I have tested this item successfully on 4ffc3d4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27718.

avatar richard67 richard67 - test_item - 2 Feb 2020 - Tested successfully
avatar richard67
richard67 - comment - 2 Feb 2020

I have tested this item successfully on 4ffc3d4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27718.

avatar richard67 richard67 - change - 2 Feb 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 2 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27718.

avatar richard67
richard67 - comment - 2 Feb 2020

Drone failure seems not to be related to this PR.

avatar rdeutz rdeutz - change - 3 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-03 21:56:27
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 3 Feb 2020
avatar rdeutz rdeutz - merge - 3 Feb 2020
avatar rdeutz
rdeutz - comment - 3 Feb 2020

@richard67 you are right the failure of drone was not realted to the PR, but then we have to restart drone to make sure it is not releated. My personal opinon is that nothing can be RTC when CI has failed.

avatar richard67
richard67 - comment - 3 Feb 2020

@rdeutz Well, then tests should be more reliable. Currently it's a kind of lotto if they fail or not.

Add a Comment

Login with GitHub to post a comment