? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
30 Jan 2020

When the language switcher is set to display flags a title is set for each image with the full language name.

But if a language is set not to have a flag then we get the SEF value instead of the flag but there is no title.

This simple PR adds the title in that situation.

To test

Create a multilingual site
Open one of the content languages and set the image value to none
Make sure the language switcher module is set to use image flags
Hover over the images and the text in the language switcher module in the front end
After this PR all languages will display the title

Expected behaviour

flag

avatar brianteeman brianteeman - open - 30 Jan 2020
avatar brianteeman brianteeman - change - 30 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2020
Category Modules Front End
avatar infograf768 infograf768 - test_item - 30 Jan 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 30 Jan 2020

I have tested this item successfully on abe9a38

Ok on review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27714.

avatar Quy Quy - test_item - 30 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 30 Jan 2020

I have tested this item successfully on abe9a38


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27714.

avatar Quy Quy - change - 30 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 30 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27714.

avatar infograf768 infograf768 - change - 31 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-31 07:20:33
Closed_By infograf768
Labels Added: ? ?
avatar infograf768 infograf768 - close - 31 Jan 2020
avatar infograf768 infograf768 - merge - 31 Jan 2020
avatar infograf768
infograf768 - comment - 31 Jan 2020

tks

avatar infograf768
infograf768 - comment - 31 Jan 2020

Please test #27734 where we have the same issue.

Add a Comment

Login with GitHub to post a comment