[#27710] - [4.0] Add category caching to routers
- Fixed in Code Base
- 3 Feb 2020
- Medium
- Build: 4.0-dev
- # 27710
- Diff
- SharkyKZ:j4/perf/router-category-cache
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27073.
Summary of Changes
Adds category caching in routers to reduce number of queries.
Testing Instructions
Create some content or install sample data.
Navigate article/contact/newsfeeds pages.
Expected result
Still works.
Documentation Changes Required
No.
joomla-cms-bot
- | Category | ⇒ | Front End com_contact com_content com_newsfeeds |
| Status | New | ⇒ | Pending |
I have tested this item
Tested com_contacts, com_newsfeed, and com_article on frontend and backend. No issues after applying PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27710.
This cache doesn't persist across requests. It's possible for a category to be deleted within the same request (e.g. if it's deleted automatically or if you delete it yourself) between instantiating the router and building the link. But so far this hasn't been an issue.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27710.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27710.
| Labels |
Added:
?
?
|
||
| Labels | |||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-03 13:33:39 |
| Closed_By | ⇒ | rdeutz |
This makes sense as a compromise for me as these are always readonly on the categories object