[#27707] - [4.0] Make alert inline consistent
- Fixed in Code Base
- 12 Feb 2020
- Medium
- Build: 4.0-dev
- # 27707
- Diff
- Quy:alert-inline
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Make alert inline consistent like this.
Testing Instructions
Go to System > Warnings
Expected result
Actual result
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
I am not sure how to handle these.
The first one has dynamic heading and description. I will have to see what possible headings are.
For the second one, can the heading be replaced with the i icon?
COM_INSTALLER_MSG_WARNINGFURTHERINFO="Further information on warnings"
<?php foreach ($this->messages as $message) : ?>
<div class="alert alert-warning">
<h4 class="alert-heading"><?php echo $message['message']; ?></h4>
<p class="mb-0"><?php echo $message['description']; ?></p>
</div>
<?php endforeach; ?>
<div class="alert alert-info">
<h4 class="alert-heading"><?php echo Text::_('COM_INSTALLER_MSG_WARNINGFURTHERINFO'); ?></h4>
<p class="mb-0"><?php echo Text::_('COM_INSTALLER_MSG_WARNINGFURTHERINFODESC'); ?></p>
</div>
just about to start a presentation. i wont be able to take a look now until tomorrow
For the first one I think we need to keep the heading but we could include the relevant icon for some consistency
For the second message you are correct
Note the exact same code is used in com_joomlaupdate so that would need updating as well
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27707.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27707.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27707.
The exact same code in joomlaupdate should be changed as well
| Labels |
Added:
?
|
||
| Category | Administration com_installer | ⇒ | Administration com_installer com_joomlaupdate |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-12 20:30:45 |
| Closed_By | ⇒ | rdeutz |
Goof spot but you need to fix the other ones in the same file as well