? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Jan 2020

This PR removes the class Table and TD from the markup in the error backtrace. Code review only needed as the class doesn't exist in the css. Or enable debug mode and then in the frontend force an error eg go to index.php?option=com_wilson

other than the removal of the classes that will be seen in the source there will be no other change

avatar brianteeman brianteeman - open - 28 Jan 2020
avatar brianteeman brianteeman - change - 28 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jan 2020
Category Layout
avatar Quy Quy - test_item - 28 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 28 Jan 2020

I have tested this item successfully on 8947d98


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27695.

avatar brianteeman
brianteeman - comment - 28 Jan 2020

@zero-24 @SniperSister can you please check the rips report here

avatar wilsonge
wilsonge - comment - 28 Jan 2020

Why am I now an example error ? ?

avatar brianteeman
brianteeman - comment - 28 Jan 2020

@wilsonge you should be glad

avatar brianteeman brianteeman - change - 30 Jan 2020
Labels Added: ?
avatar zero-24
zero-24 - comment - 3 Feb 2020

rips seams to be happy now. We had issues with false positives in the last days.

avatar brianteeman
brianteeman - comment - 3 Feb 2020

@zero-24 Thanks for checking

avatar wilsonge wilsonge - change - 3 Feb 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-03 23:40:18
Closed_By wilsonge
avatar wilsonge wilsonge - close - 3 Feb 2020
avatar wilsonge wilsonge - merge - 3 Feb 2020
avatar wilsonge
wilsonge - comment - 3 Feb 2020

Thanks!

avatar brianteeman
brianteeman - comment - 3 Feb 2020

Thanks - would be good to clear the pr backlog before the end of the week

Add a Comment

Login with GitHub to post a comment