Conflicting Files ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
28 Jan 2020

Summary of Changes

Moves namespaced extension code to src subdirectory.

Testing Instructions

Apply patch. Delete libraries/autoload_psr4.php file. Test that Joomla still works.

Documentation Changes Required

IDK.

avatar SharkyKZ SharkyKZ - open - 28 Jan 2020
avatar SharkyKZ SharkyKZ - change - 28 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jan 2020
Category Administration com_admin com_associations
avatar SharkyKZ SharkyKZ - change - 28 Jan 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 28 Jan 2020
avatar laoneo
laoneo - comment - 28 Jan 2020

Had a hard fight for restructuring already #1522.

avatar brianteeman
brianteeman - comment - 28 Jan 2020

@laoneo is that the correct link?

avatar Bakual
Bakual - comment - 28 Jan 2020

#15221 is the correct one.

avatar laoneo
laoneo - comment - 28 Jan 2020

@Bakual has the right one

avatar wilsonge
wilsonge - comment - 28 Jan 2020

Still don't like it. feel i'm being outvoted by popular opinion tho. so if you wanna merge @laoneo feel free

avatar joeforjoomla
joeforjoomla - comment - 28 Jan 2020

Agree with @wilsonge. Still don't like it and i don't see a real benefit or best practice here. Not a PHP application, just overcomplicating all components, modules, plugins for nothing

avatar Bakual
Bakual - comment - 28 Jan 2020

I also still don't like it.
In the end it's just a bandaid to cope with the lowercase/uppercase issue. We need a proper solution there so we don't have to needless move files around.

avatar laoneo
laoneo - comment - 28 Jan 2020

I mean we can start the debate again. But I guess #15221 has already all the pros and cons. I still like it when the root folder is not also managed by the classloader.

avatar SharkyKZ SharkyKZ - change - 28 Jan 2020
Labels Added: ?
avatar HLeithner
HLeithner - comment - 28 Jan 2020

At least consistent in core would be great.

avatar laoneo
laoneo - comment - 29 Jan 2020

For me it looks much nicer like
image

than
image

avatar SharkyKZ SharkyKZ - change - 13 Feb 2020
Labels Added: Conflicting Files
avatar laoneo laoneo - change - 13 Feb 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-13 09:11:18
Closed_By laoneo
avatar laoneo laoneo - close - 13 Feb 2020
avatar laoneo laoneo - merge - 13 Feb 2020
avatar laoneo
laoneo - comment - 13 Feb 2020

Thanks @SharkyKZ!! It is a step into the right direction. Especially for the extensions which do have a vendor folder. So we don't have the the same folder managed by two classloaders.

avatar richard67
richard67 - comment - 13 Feb 2020

We need a proper solution there so we don't have to needless move files around.

Yes, regardless of this PR here we need a solution in case if we again have some mistake in case-sensitive file names which later has to be corrected with an update.

Is there anybody out the willing and having the necessary knowledge to work on that? maybe @HLeithner has ideas?

avatar laoneo
laoneo - comment - 13 Feb 2020

Where do we have that issue @richard67 ?

avatar richard67
richard67 - comment - 13 Feb 2020

@laoneo We will have this issue again as soon as someone adds some class file and the file does not have the right case-sensitive name. This happened sometimes in past and was one reason for moving around files. See comments e.g. by @Bakual above.

P.S. Problem was that replacing the files with the new name by unpacking the update package doesn't really work on Windows. When you have e.g. a file "Heinz.php" and find out it should be "heinz.php" and so rename it in the repo, it will be "heinz.php" in the package, which is right, but when unpacking that package and so overwriting "Heinz.php", Windows will keep the old name "Heinz.php" for that file just having been unpacked. That's why we moved files around, because when unpacking the update package, Windows will not find a file to overwrite and so use the case as it is in tha packkage ("heinz.php").

avatar HLeithner
HLeithner - comment - 13 Feb 2020

For example:
#23725 (there is also a PoC for the solution)

And here:
#25279 (comment)

avatar richard67
richard67 - comment - 13 Feb 2020

@HLeithner Thanks. Will check on weekend if I understand it and if necessary talk with you on Glip about what to be done and if I can do it (in case you don't have time). Maybe we also should discuss on Glip in the maintenance team to see what the opinions are, if such solution would be accepted. I think we need a way to rename "Heinz.php" to "heinz.php" on Windows, and as far as I did read there should be ways to do that with PHP. If that will also work for "Hugo.php" is another question (joking) ;-)

Add a Comment

Login with GitHub to post a comment