? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
26 Jan 2020

Summary of Changes

Cleans up Joomla\Component\Content\Administrator\Field\VoteRadioField so that it's either attached to the form or not instead of hiding/showing label and options.

Testing Instructions

Go to Articles configuration.
In List Layouts tab check that Show Votes in List and Show Ratings in List fields appear when Content - Vote plugin is enabled. And don't appear when the plugin is disabled.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 26 Jan 2020
avatar SharkyKZ SharkyKZ - change - 26 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2020
Category Administration com_content
197f4dc 26 Jan 2020 avatar SharkyKZ CS
avatar SharkyKZ SharkyKZ - change - 26 Jan 2020
Labels Added: ?
avatar Quy Quy - test_item - 26 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 26 Jan 2020

I have tested this item successfully on 9653205


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27656.

avatar jwaisner jwaisner - test_item - 26 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 26 Jan 2020

I have tested this item successfully on 9653205


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27656.

avatar Quy Quy - change - 27 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 27 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27656.

avatar rdeutz
rdeutz - comment - 3 Feb 2020

please don't change the @SInCE tag

avatar SharkyKZ
SharkyKZ - comment - 3 Feb 2020

Which one?

The first I corrected because in 3.7.1 VoteList field was introduced. In 3.8.0 it was replaced by VoteRadio (this field). So 3.8.0 is correct version. Or not?

avatar rdeutz
rdeutz - comment - 3 Feb 2020

Commented on code

avatar rdeutz rdeutz - change - 3 Feb 2020
Labels Added: ?
avatar rdeutz rdeutz - change - 3 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-03 17:22:46
Closed_By rdeutz
avatar rdeutz rdeutz - close - 3 Feb 2020
avatar rdeutz rdeutz - merge - 3 Feb 2020

Add a Comment

Login with GitHub to post a comment