Feeling Lucky
?
[#27653] - Fix Joomla Update undefined variable
- Closed
- 26 Jan 2020
- Medium
- Build: 4.0-dev
- # 27653
- Diff
- wilsonge:undefined_var
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27649 .
Summary of Changes
Fixes us using an undefined variable causing a PHP notice (correctly) in PHP 7.4
Testing Instructions
Check Joomla Update in PHP 7.4 before patch php notice, after patch no notice (else code review - variable ftp doesn't exist in the class but $ftp does exist and is used in a similar way further up in the code
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
brianteeman
- comment
- 26 Jan 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27653.
wilsonge
- comment
- 26 Jan 2020
Closing as this will get fixed by merging up the latest staging branch
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-26 14:43:59 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
This should be done the other way around like in staging (#27219).
$this->ftpis also used in layouts.