? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
25 Jan 2020

Summary of Changes

Namespaces System - Privacy Consent plugin.

Testing Instructions

Apply patch. Delete libraries/autoload_psr4.php file.
Enable System - Confirm Consent plugin.
Login to frontend.
When redirected to profile form to accept consent check that Privacy Policy field appears correctly.

Documentation Changes Required

IDK.

avatar SharkyKZ SharkyKZ - open - 25 Jan 2020
avatar SharkyKZ SharkyKZ - change - 25 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jan 2020
Category Front End Plugins
avatar SharkyKZ SharkyKZ - change - 25 Jan 2020
Labels Added: ?
avatar jwaisner jwaisner - test_item - 26 Jan 2020 - Tested unsuccessfully
avatar jwaisner
jwaisner - comment - 26 Jan 2020

I have tested this item ? unsuccessfully on ec00dac

Privacy consent at bottom of profile is missing after applying patch and removing libraries/autoload_psr4.php.

I am noticing that when reversing the patch I am getting a warning that plugins/system/privacyconsent/src/Field/PrivacyField.php does not exists. I am not sure if the patch is not applying correctly or something is missing from the patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27645.

avatar SharkyKZ
SharkyKZ - comment - 26 Jan 2020

Sounds like the patch wasn't applied correctly. Do you have GitHub Authentication set up in Patchtester? If not, maybe running into request limits.

avatar jwaisner
jwaisner - comment - 26 Jan 2020

Even using and IDE (Eclipse) to apply from the PR it still has a problem reverting the patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27645.

avatar jwaisner
jwaisner - comment - 17 Mar 2020

@SharkyKZ Patch is still referencing a non-existant directory. If we need to move data due to a structure change can you please include those instructions in the patch notes? I tried with Patchtester and via my IDE and both did not work properly.

avatar chmst
chmst - comment - 17 Mar 2020

I have tested this item successfully on 6974cae

I tested this successfully had to do applied the patch manually in the IDE.

The structure now is

forms/privacyconsent.php
src/Field/privacy.php
privacyconsent.php
privacyconsent.xml


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27645.
avatar chmst chmst - test_item - 17 Mar 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 18 Mar 2020

I have tested this item successfully on 6974cae

Test is good. Thanks @chmst for the additional instruction.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27645.

avatar jwaisner jwaisner - test_item - 18 Mar 2020 - Tested successfully
avatar jwaisner jwaisner - change - 18 Mar 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 18 Mar 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27645.

avatar zero-24 zero-24 - change - 18 Mar 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-18 03:33:06
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 18 Mar 2020
avatar zero-24 zero-24 - merge - 18 Mar 2020
avatar zero-24
zero-24 - comment - 18 Mar 2020

Thanks merged. First merge with the new GitHub App, works awesome :-D

Add a Comment

Login with GitHub to post a comment