Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#27641] - [4.0] Namespace Content - Confirm Consent plugin

? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
25 Jan 2020

Summary of Changes

Namespaces Content - Confirm Consent plugin.

Testing Instructions

Apply patch. Delete libraries/autoload_psr4.php file.
Enable Content - Confirm Consent plugin.
Create a contact with email.
View the contact form in frontend.
Check that consent checkbox appears in the form.

Documentation Changes Required

IDK.

avatar SharkyKZ SharkyKZ - open - 25 Jan 2020
avatar SharkyKZ SharkyKZ - change - 25 Jan 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jan 2020
Category ⇒ Front End Plugins
avatar SharkyKZ SharkyKZ - change - 25 Jan 2020
Labels Added: ?
avatar SharkyKZ SharkyKZ - change - 25 Jan 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 25 Jan 2020
avatar SharkyKZ SharkyKZ - change - 25 Jan 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 25 Jan 2020
avatar jwaisner
jwaisner - comment - 26 Jan 2020

After applying patch the consent checkbox and link are broken.

AFTER
27641

BEFORE
27641-2

avatar jwaisner jwaisner - test_item - 26 Jan 2020 - Tested unsuccessfully
avatar jwaisner
jwaisner - comment - 26 Jan 2020

I have tested this item ? unsuccessfully on b7a5c00

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27641.

avatar jwaisner
jwaisner - comment - 26 Jan 2020

Also looks like Composer had to be reran after applying the patch which was not included in the instructions, but even after running that (using Git and Patchtester) I still have the same issue.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27641.

avatar SharkyKZ
SharkyKZ - comment - 26 Jan 2020

@jwaisner did you delete libraries/autoload_psr4.php file after applying patch? Running Composer is not required.

avatar jwaisner
jwaisner - comment - 26 Jan 2020

yes, that file was deleted after I applied the patch.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27641.

f54d303 26 Jan 2020 avatar SharkyKZ Align
avatar jwaisner jwaisner - test_item - 28 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 28 Jan 2020

I have tested this item ✅ successfully on f54d303

After latest commit the patch applies correctly. All looks good.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27641.

avatar chmst chmst - test_item - 9 Feb 2020 - Tested unsuccessfully
avatar chmst
chmst - comment - 9 Feb 2020

I have tested this item ? unsuccessfully on f54d303

The field is required, but if it is noch checked, it has not the aria-invalid="false" and is not marked by a red border.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27641.
avatar SharkyKZ
SharkyKZ - comment - 9 Feb 2020

@chmst Not related to this PR.

avatar chmst chmst - test_item - 9 Feb 2020 - Tested successfully
avatar chmst
chmst - comment - 9 Feb 2020

I have tested this item ✅ successfully on f54d303

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27641.

avatar chmst
chmst - comment - 9 Feb 2020

Sorry. The checkbox itself is all right

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27641.

avatar SharkyKZ SharkyKZ - change - 9 Feb 2020
Status Pending ⇒ Ready to Commit
avatar SharkyKZ
SharkyKZ - comment - 9 Feb 2020

RTC.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27641.

avatar rdeutz rdeutz - change - 10 Feb 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-02-10 07:18:37
Closed_By ⇒ rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 10 Feb 2020
avatar rdeutz rdeutz - merge - 10 Feb 2020

Add a Comment

Login with GitHub to post a comment