? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Jan 2020

This PR addresses some of the issues for #23911

Specifically numbers
2, 4, 6

There are others that need to be addressed relating to the actual lists themselves but I a not sure if the list is even remotely accessible so wish to tackle that in a desperate issue

avatar brianteeman brianteeman - open - 25 Jan 2020
avatar brianteeman brianteeman - change - 25 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jan 2020
Category Administration com_modules Templates (admin)
avatar brianteeman brianteeman - change - 25 Jan 2020
The description was changed
avatar brianteeman brianteeman - edited - 25 Jan 2020
avatar Quy
Quy - comment - 25 Jan 2020

Out of curiosity, should there be a space before All so screenreaders don't read them as one word?
<span class="sr-only">Expand</span>All

avatar infograf768
infograf768 - comment - 26 Jan 2020

Out of curiosity, should there be a space before All so screenreaders don't read them as one word?

In any case, it looks like this is not compatible with languages where the order would be different, i.e. where the equivalent of the Select verb has to be placed after the All or None object.

I'm afraid the only solution is to create new strings of the type:
COM_MODULES_EXPAND_ALL etc.

avatar brianteeman brianteeman - change - 21 Feb 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 21 Feb 2020
Category Administration com_modules Templates (admin) Administration com_modules Language & Strings Templates (admin)
avatar brianteeman
brianteeman - comment - 21 Feb 2020

Changed the approach to use an aria-label instead as it will allow better translation as highlighted by @infograf768
Also re-ordered the language file

avatar brianteeman
brianteeman - comment - 26 Feb 2020

Could someone please fix drone

avatar HLeithner HLeithner - change - 26 Feb 2020
Labels Added: ?
avatar HLeithner
HLeithner - comment - 26 Feb 2020

@brianteeman can you merge the latest changes into this branch please?

avatar brianteeman
brianteeman - comment - 26 Feb 2020

@HLeithner its not showing me that option or any merge issues

image

avatar HLeithner
HLeithner - comment - 5 Mar 2020

@brianteeman I have no idea why it doesn't work can you create a new PR please?

avatar HLeithner HLeithner - close - 5 Mar 2020
avatar HLeithner HLeithner - change - 5 Mar 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-03-05 19:37:59
Closed_By HLeithner
avatar brianteeman
brianteeman - comment - 6 Mar 2020

Done see #28250

Add a Comment

Login with GitHub to post a comment