? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
24 Jan 2020

More changes for PR #27153.

Summary of Changes

Fix styling.

Testing Instructions

Go to Global Configuration > Articles
See missing white background.

Expected result

after

Actual result

before

avatar Quy Quy - open - 24 Jan 2020
avatar Quy Quy - change - 24 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jan 2020
Category Administration com_config
avatar ChristineWk ChristineWk - test_item - 24 Jan 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 24 Jan 2020

I have tested this item successfully on e6629d0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27628.

avatar Quy Quy - change - 24 Jan 2020
Labels Added: ?
avatar ChristineWk ChristineWk - test_item - 24 Jan 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 24 Jan 2020

I have tested this item successfully on 3c45a14

tested Code View


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27628.

avatar richard67
richard67 - comment - 25 Jan 2020

tested Code View

@ChristineWk Does that mean you have tested by code review and not with a real test?

avatar richard67 richard67 - test_item - 25 Jan 2020 - Tested successfully
avatar richard67
richard67 - comment - 25 Jan 2020

I have tested this item successfully on 3c45a14


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27628.

avatar richard67
richard67 - comment - 25 Jan 2020

I suggest to wait with RTC until we know if the other was a real test or not. Code review is not a sufficient test in this case in my opinion.

avatar Quy
Quy - comment - 25 Jan 2020

I think she is referring to the additional commit after her initial test.

avatar richard67
richard67 - comment - 25 Jan 2020

Well if you want, make it RTC.

avatar Quy
Quy - comment - 25 Jan 2020

RTC

avatar ChristineWk
ChristineWk - comment - 25 Jan 2020

I think she is referring to the additional commit after her initial test.

Yes. As I didn't remember the previous layout concerning column layout from 1st test, I checked Code review also.

avatar richard67
richard67 - comment - 25 Jan 2020

@ChristineWk Thanks for testing and clarification.

avatar Quy Quy - change - 25 Jan 2020
Status Pending Ready to Commit
avatar Quy Quy - change - 25 Jan 2020
Labels Added: ?
avatar Quy Quy - change - 25 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-25 14:26:40
Closed_By Quy
avatar Quy Quy - close - 25 Jan 2020
avatar Quy Quy - merge - 25 Jan 2020

Add a Comment

Login with GitHub to post a comment