[#27615] - [4.0] Global configuration options add media-breakpoint-down(sm)
- Fixed in Code Base
- 24 Jan 2020
- Medium
- Build: 4.0-dev
- # 27615
- Diff
- astridx:ux2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27613 (comment) .
Summary of Changes
I added a media-breakpoint-down(sm) for the options. On small devices the label ob an option is above this option.
Testing Instructions
- Open Global Configuration an see that all options displayed beside the label.
- Apply this patch and run
npm ci - Open Global Configuration again and see, that the options on small devices is displayed in there own row above the label.
Expected result
Actual result
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
@richard67 It is not necessary to test both PRs together. Both can be tested independently.
@richard67 No, I hadn't applied both PRs together. A column was previously set on small displays.
@richard67 Thank you very much for testing :)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27615.
Confirmed.
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27615.
Oops, I didn't notice that either.
@richard67 I added the need to run npm ci in the test descriptions.
| Labels |
Added:
?
|
||
| Category | Administration Templates (admin) | ⇒ | Administration Templates (admin) Libraries |
The label for the switch was not shown because the surrounding div had the class sr-only. I have now changed this. I see no reason why this should be screenreader-only sr-only.
Switcher should be under label.
Issue with switcher labels is due to the presence of a float for .control-group .control-label
plus we have 2 instances of the label, one as label the other as legend
| Category | Administration Templates (admin) Libraries | ⇒ | Administration Templates (admin) External Library Composer Change |
| Labels |
Added:
?
|
||
| Category | Administration Templates (admin) External Library Composer Change | ⇒ | Administration Templates (admin) |
| Labels |
Removed:
?
|
||
@infograf768 Thank for pointing me in the right direction.
Please have a look to see if it fits now.
I intentionally made the changes in file /administrator/templates/atum/scss/blocks/_form.scss.
I think that the file /build/media_source/system/scss/fields/switcher.scss should remain independent of the number of columns.
Do you also see it like that?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27615.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27615.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27615.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27615.
Thanks! Can you also please look into the Permissions tab in a separate PR?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-24 23:28:58 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
@astridx When testing this PR here, shall we also apply PR #27613 ? If yes, then please mention that in testing instructions.