Feeling Lucky
?
[#2761] - Import the user plugins for onUserLoginFailure
- Closed
- 14 Jul 2014
- Medium
- Build: staging
- # 2761
- Diff
- pasamio:patch-1
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
The onUserLoginFailure trigger is a user plugin method however on the failure code path, it isn't loaded. So this changes that to put it on the main code path ahead of the failure check.
roland-d
- comment
- 12 Jul 2014
@test: works as expected. After applying the patch the onUserLoginFailure() is triggered in the frontend.
Is this supposed to be triggered in the backend as well?
There is a CS issue in the PR:
:10: trailing whitespace.
JPluginHelper::importPlugin('user');
warning: 1 line adds whitespace errors.
pasamio
- comment
- 12 Jul 2014
Fixed the whitespace error.
Bakual
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-07-14 19:25:04 |
Thanks Sam!
This seems like a logical fix. Is there a tracker item for this and/or
testing instructions?
Best,
Matt Thomas
@betweenbrain
http://matt-thomas.me/
http://betweenbrain.com/
https://github.com/betweenbrain
Sent from mobile. Please pardon any typos or brevity.
On Jan 6, 2014 12:37 PM, "Sam Moffatt" notifications@github.com wrote: