? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
23 Jan 2020

Summary of Changes

Removes an import which isn't needed for a very long time.

Testing Instructions

Temporarily set text filtering to No HTML for Super Users in Global Configuration -> Text Filters.
Create a Custom HTML module with some HTML content.
Save and check that HTML is stripped out after saving.

Expected result

Works like before.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 23 Jan 2020
avatar SharkyKZ SharkyKZ - change - 23 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jan 2020
Category Administration com_modules
avatar richard67
richard67 - comment - 23 Jan 2020

@SharkyKZ Site module? Or admin module? Or doesn't matter which kind?

avatar richard67
richard67 - comment - 23 Jan 2020

@SharkyKZ Have just tested and am confused. Followed the testing instructions but HTML isn't stripped off, not without this PR and also not with this PR. What am I doing wrong?

avatar SharkyKZ
SharkyKZ - comment - 23 Jan 2020

Doesn't matter which module. Did you set filtering to No HTML in your user group?

avatar SharkyKZ SharkyKZ - change - 23 Jan 2020
Labels Added: ?
avatar richard67
richard67 - comment - 23 Jan 2020

@SharkyKZ Yes, like you wrote, in global config for the super users, and I was working with the only one user who is a super user.

avatar SharkyKZ
SharkyKZ - comment - 23 Jan 2020

Since you're experiencing this without patch, you might want to open a separate issue. Though I can't replicate it.

avatar richard67
richard67 - comment - 23 Jan 2020

@SharkyKZ Not sure if it's an issue. Maybe I'm doing something wrong? Am using current 4.0-dev branch on a git clone, i.e. no nightly or alpha.

avatar richard67 richard67 - test_item - 23 Jan 2020 - Tested successfully
avatar richard67
richard67 - comment - 23 Jan 2020

I have tested this item successfully on 9fa4331

Was a bit tricky with TinyMCE settings to get the Joomla Filter being used, but after I've managed that, all works as expected with and without this PR.
So the PR doesn't break anything.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27608.

avatar jwaisner jwaisner - test_item - 28 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 28 Jan 2020

I have tested this item successfully on 9fa4331


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27608.

avatar SharkyKZ SharkyKZ - change - 28 Jan 2020
Status Pending Ready to Commit
avatar SharkyKZ
SharkyKZ - comment - 28 Jan 2020

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27608.

avatar wilsonge wilsonge - change - 28 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-28 10:37:25
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 28 Jan 2020
avatar wilsonge wilsonge - merge - 28 Jan 2020
avatar wilsonge
wilsonge - comment - 28 Jan 2020

Thanks!

Add a Comment

Login with GitHub to post a comment