[#27590] - [4.0] Check permissions against com_menus for "save2menu" button
- Fixed in Code Base
- 23 Feb 2020
- Medium
- Build: 4.0-dev
- # 27590
- Diff
- Bakual:40FixPermissionSave2Menu
User tests: Successful: Unsuccessful:
Pull Request for Issue #27581 .
Summary of Changes
Changing permission check so it actually checks if the user is allowed to create a menuitem.
Testing Instructions
Create a user which isn't allowed to create a menuitem.
Create or edit an article and see if the "Save to Menu" appears (in the save dropdown)
Test also with a user which is allowed to create a menuitem.
Expected result
Button only appears if user is allowed to create a menuitem
Actual result
Button always appears
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
| Labels |
Added:
Conflicting Files
?
|
||
Rebased. There were no conflicts to solve.
shame on me
can you tell me how to create that kind of user step by step
Create a user which isn't allowed to create a menuitem.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27590.
- Create a new user account, assign him to Administrator user group
- Go to Menus -> Manage, click on Options button in the toolbar, click o Permissions tab, select Administrator user group, set Create permission to Denied.
Now users from Administrator user group won't have create menu item permission...
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27590.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27590.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-23 20:41:03 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
Removed: Conflicting Files |
||
Thanks.
@Bakual please can you solve conflict