? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
21 Jan 2020

Pull Request for Issue #27553.

Summary of Changes

Display true/false instead 1/blank respectively to match in the configuration file.

Testing Instructions

Go to System > System Information > Configuration File
offline is blank.
mailonline is 1.
Apply PR.
offline is false.
mailonline is true.

avatar Quy Quy - open - 21 Jan 2020
avatar Quy Quy - change - 21 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jan 2020
Category Administration com_admin
avatar Quy Quy - change - 21 Jan 2020
The description was changed
avatar Quy Quy - edited - 21 Jan 2020
avatar jwaisner jwaisner - test_item - 22 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 22 Jan 2020

I have tested this item successfully on 46a9ad5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27588.

avatar jwaisner
jwaisner - comment - 22 Jan 2020

@Quy Will we be looking to correct the display_offline_message, captcha, and access fields to reflect similar? It may need to be a separate PR for that.

avatar Quy
Quy - comment - 22 Jan 2020

No as these are dropdowns with several options.

Offline Message
Default Captcha
Default Access Level

avatar infograf768 infograf768 - test_item - 23 Jan 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 23 Jan 2020

I have tested this item successfully on 46a9ad5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27588.

avatar infograf768 infograf768 - change - 23 Jan 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 23 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27588.

avatar infograf768 infograf768 - change - 23 Jan 2020
Labels Added: ?
avatar Quy Quy - change - 25 Jan 2020
Labels Added: ?
avatar wilsonge wilsonge - change - 25 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-25 23:59:14
Closed_By wilsonge
avatar wilsonge wilsonge - close - 25 Jan 2020
avatar wilsonge wilsonge - merge - 25 Jan 2020
avatar wilsonge
wilsonge - comment - 25 Jan 2020

Thanks!

Add a Comment

Login with GitHub to post a comment