[#27582] - [4.0] Correct ID in ordering field
- Fixed in Code Base
- 25 Jan 2020
- Medium
- Build: 4.0-dev
- # 27582
- Diff
- SharkyKZ:j4/ordering-field
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27514.
Summary of Changes
Corrects <select> element IDs in ordering fields.
Testing Instructions
Edit a plugin.
Inspect markup of Ordering field.
Expected result
<select> element has id="jform_ordering".
Actual result
Element has id="jformordering".
Documentation Changes Required
New argument added to JHtmlList::ordering().
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Rel_Number | ⇒ | 27514 | |
| Relation Type | ⇒ | Pull Request for | |
| Labels |
Added:
?
|
||
Should the number be displayed? Let's do like menus where it is not and First/Last are more obvious.
Should the number be displayed?
I have no preference. But even if we change this to be like the menu field, this PR is still needed to fix the issues in the Joomla\CMS\Form\Field\OrderingField class, in case someone extends it.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27582.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27582.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27582.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-25 23:52:09 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 135cf3b
After applying PR, markup changes to correct id="jform_ordering". Also confirmed that the order field saves changes.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27582.