? ? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
19 Jan 2020

Pull Request for Issue #27565 .

Summary of Changes

Removes the SVG curve from the frontend template header

Testing Instructions

Apply patch and run node build.js --compile-css to update the changed SCSS.

Add banner module to banner position

Before PR

Banner cropped by SVG

After PR

Banner is visible

Documentation Changes Required

No

avatar ciar4n ciar4n - open - 19 Jan 2020
avatar ciar4n ciar4n - change - 19 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jan 2020
Category Front End Templates (site)
avatar infograf768
infograf768 - comment - 19 Jan 2020

Great.
Remains one aspect: the Module Class. What do we do with that?
Screen Shot 2020-01-19 at 12 34 18

avatar infograf768 infograf768 - change - 19 Jan 2020
Labels Added: ?
avatar ciar4n
ciar4n - comment - 19 Jan 2020

Not sure I understand what you mean. Is it missing from the output?

avatar infograf768
infograf768 - comment - 19 Jan 2020

Is it missing from the output?

As far as I see , yes.

avatar infograf768
infograf768 - comment - 19 Jan 2020

I think it comes from
<jdoc:include type="modules" name="banner" style="xhtml" />

Cardgrey and default chromes contain <?php echo htmlspecialchars($params->get('moduleclass_sfx')

not xhtml

avatar ciar4n
ciar4n - comment - 19 Jan 2020

I've changed the style to html5 which appears to be the only chrome with no styling and adds the class. It appears default applies card styling to the module which is incorrect imo and possibly needs changing (separate issue/pr).

avatar infograf768
infograf768 - comment - 19 Jan 2020

On ipad, will test later.
In j3, chromes are defined in system.
Except for the specific chromes which are defined in the template itself, do you have an idea where are defined html5 and xhtml in j4 ?

avatar ciar4n
ciar4n - comment - 19 Jan 2020

System chromes are in ../layouts/chromes/

avatar infograf768 infograf768 - test_item - 19 Jan 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 19 Jan 2020

I have tested this item successfully on bdcce04

Looks fine here.

we get <div class="moduletable mybannerclass"> which is fine.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27566.

avatar ciar4n ciar4n - change - 19 Jan 2020
The description was changed
avatar ciar4n ciar4n - edited - 19 Jan 2020
avatar infograf768
infograf768 - comment - 20 Jan 2020

@ciar4n
Looks like we have also another xhtml style in error.php

<?php if ($this->countModules('banner')) : ?>
		<div class="grid-child container-banner">
			<jdoc:include type="modules" name="banner" style="xhtml" />
		</div>
avatar ChristineWk ChristineWk - test_item - 20 Jan 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 20 Jan 2020

banner
I have tested this item successfully on aee0cc4

Tested hours before, but after applying Patch, I got error 404 and: Call to undefined method Joomla\CMS\WebAsset\WebAssetManager::usePreset()
Then I found: brianteeman@7fa8d42
My site was from oct2019, therefore checked above files. Finally installed now completely new nightly build from today.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27566.

avatar jwaisner jwaisner - test_item - 21 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 21 Jan 2020

I have tested this item successfully on aee0cc4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27566.

avatar infograf768 infograf768 - change - 21 Jan 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 21 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27566.

avatar infograf768 infograf768 - close - 21 Jan 2020
avatar infograf768 infograf768 - merge - 21 Jan 2020
avatar infograf768 infograf768 - change - 21 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-21 10:03:17
Closed_By infograf768
Labels Added: ?
avatar infograf768
infograf768 - comment - 21 Jan 2020

tks

avatar Scrabble96
Scrabble96 - comment - 31 Jan 2020

Sorry, I know the original issue was posted by me, but I'm unable to test this; I'm waiting for a new computer :-( which should arrive sometime next week.

Add a Comment

Login with GitHub to post a comment