? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
18 Jan 2020

Summary of Changes

This fix a bug, when the params tab become empty if one of the field is a subform with own fieldset

Testing Instructions

Apply patch.
Add next subform field to Custom HTML module (in <fieldset name="options"):

<field name="test_fields" type="subform" label="test_fields"
  filter="FooBar::filterTest" multiple="true" min="1" groupByFieldset="true">
   <form>
    <fieldset name="test1" label="fieldset 1">
     <field name="test_field" type="text" label="TESTFIELD1"/>
    </fieldset>
    <fieldset name="test2" label="fieldset 2">
     <field name="test_field2" type="text" label="TESTFIELD2"/>
    </fieldset>
   </form>
</field>

Open the module for editing, check the options tab (or where field was added)

Expected result

you see there all fields, and subform field also

Actual result

the tab are empty

avatar Fedik Fedik - open - 18 Jan 2020
avatar Fedik Fedik - change - 18 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jan 2020
Category Layout
avatar Fedik
Fedik - comment - 18 Jan 2020

@N6REJ please test

avatar N6REJ
N6REJ - comment - 26 Jan 2020

could not test via patchtester so applied changes manually and it works properly.

avatar Quy
Quy - comment - 24 Mar 2020

I have tested this item successfully on 1be3055


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27563.

avatar Quy Quy - change - 24 Mar 2020
Status Pending Ready to Commit
avatar Quy Quy - test_item - 24 Mar 2020 - Tested successfully
avatar Quy
Quy - comment - 24 Mar 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27563.

avatar wilsonge wilsonge - change - 24 Mar 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-24 23:24:12
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 24 Mar 2020
avatar wilsonge wilsonge - merge - 24 Mar 2020
avatar wilsonge
wilsonge - comment - 24 Mar 2020

Thanks!

Add a Comment

Login with GitHub to post a comment