[#27561] - Fix regression that not allow to use a custom filter with subform field
- Fixed in Code Base
- 20 Feb 2020
- Medium
- Build: staging
- # 27561
- Diff
- Fedik:subform-f-v
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Fix regression that not allow to use a custom filter with subform field, was introduced by one of previous update.
Testing Instructions
Apply patch, create a subform field , somwhere in CustomHTML module, with custom filter:
<field name="test_fields" type="subform" label="test_fields"
filter="FooBar::filterTest" multiple="true" min="1">
<form>
<field name="test_field" type="text" label="TESTFIELD1"/>
</form>
</field>Add custom filter class, somwhere in bottom of plugins/system/debug/debug.php:
class FooBar
{
static function filterTest($value)
{
JFactory::getApplication()
->enqueueMessage('Filter works: ' . json_encode($value));
return $value;
}
}Then create a Custom module in backed, and try save it.
Look for the message you got
Expected result
You should get 2 message:
Filter works: {"test_fields0":{"test_field":""}}
and
Module saved
Actual result
You get 1 message
Module saved
that means the custom filter was ignored
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27561.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27561.
@joomla/security please review this as this addressed a specific vulnerability in the past
@joel-lupfer @SniperSister Any additional input here?
| Labels |
Added:
?
?
|
||
@joel-lupfer @SniperSister Any additional input here?
@richard67 fine for me!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-20 22:38:14 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on da9a1bb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27561.