[#27548] - [4.0] Ignore failed action log notifications
- Fixed in Code Base
- 9 Mar 2020
- Medium
- Build: 4.0-dev
- # 27548
- Diff
- SharkyKZ:j4/actionlogs-mail
- Success Hound No violations found. Woof! Details
- Pending continuous-integration/drone/pr Build is running Details
- Pending continuous-integration/appveyor/pr Waiting for AppVeyor build to complete Details
User tests: Successful: Unsuccessful:
Summary of Changes
When sending action log notification emails fails, saving content items fails. This change behavior to ignore failed notifications.
Also suppresses warning message when sending mail is disabled in Global Configuration.
Testing Instructions
As super admin, edit your account.
In User Actions Log Options enable Email Notifications option and email to something invalid me@localhost.
As a different user, do something loggable, e.g. login or edit your profile.
- In Global Configuration disable
Send Mailoption. Do something loggable.
Expected result
- Works.
- No messages.
Actual result
-
Invalid address (to): me@localhost
-
The mail function has been disabled by an administrator.
Documentation Changes Required
IDK.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27548.
| Title |
|
||||||
| Title |
|
||||||
PR updated. It can be tested now.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27548.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27548.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27548.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-09 11:53:56 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 8b60a8e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27548.