? ?
avatar C-Lodder
C-Lodder
15 Jan 2020

Steps to reproduce the issue

  1. To go the Template Manager
  2. Open Atum
  3. Go to the "Colour Settings" tab
  4. Hover over coloured squares to the left of the HEX value (shown in screenshot)

Expected result

A default or pointer cursor

Actual result

A text cursor

screeny2

avatar C-Lodder C-Lodder - open - 15 Jan 2020
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jan 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 15 Jan 2020
avatar brianteeman
brianteeman - comment - 15 Jan 2020
avatar C-Lodder
C-Lodder - comment - 15 Jan 2020

Yup. But seeing as the last release of jQuery MiniColor was in Dec 2018, I assume they won't be patching this, so may have to be fixed here

avatar brianteeman
brianteeman - comment - 15 Jan 2020

i dont even know why we are still using it

avatar C-Lodder
C-Lodder - comment - 15 Jan 2020

Hopefully #25162 gets resurrected

avatar brianteeman
brianteeman - comment - 15 Jan 2020

The code to change this is easy - I just dont know where to put it

span.minicolors-swatch-color {
    cursor: pointer;
}
avatar brianteeman
brianteeman - comment - 15 Jan 2020

Hopefully #25162 gets resurrected

The code is still there but the lack of support for transparency in the native color pickers seems to have killed it

avatar C-Lodder
C-Lodder - comment - 15 Jan 2020

administrator\templates\atum\scss\vendor\minicolors\minicolors.scss

avatar brianteeman
brianteeman - comment - 15 Jan 2020

The front end would need it as well

avatar C-Lodder
C-Lodder - comment - 15 Jan 2020

templates\cassiopeia\scss\vendor_minicolors.scss

avatar brianteeman
brianteeman - comment - 15 Jan 2020

Not a fan. Third party templates need it too

avatar C-Lodder
C-Lodder - comment - 15 Jan 2020

build\media_source\system\scss_jquery-minicolors.scss

avatar brianteeman
brianteeman - comment - 15 Jan 2020

thanks - will do it after the flight - this scss isnt being generated at the moment :(


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27538.

avatar N6REJ
N6REJ - comment - 15 Jan 2020

@brianteeman according to https://github.com/Simonwep/pickr pickr is fully accessible

avatar alikon alikon - change - 15 Jan 2020
Labels Added: ?
avatar alikon alikon - labeled - 15 Jan 2020
avatar brianteeman
brianteeman - comment - 26 Jan 2020

It is absolutely not accessible with a screen reader

avatar Simonwep
Simonwep - comment - 4 Feb 2020

@brianteeman Maintainer of pickr here ?
Accessibility was discussed in this thread which was closed and required features implemented by @NateSeymour. lacymorrow also tested it with the Google's Accessibility Developer Tools here and added missing features in this PR.

I myself, and my fellow maintainer, are not experts in accessibility - although we try our best to make it as accessible as possible. If you encounter any issues or got ideas of how to improve it you may want to add a comment to this issue and I'll reopen it ?

avatar brianteeman
brianteeman - comment - 4 Feb 2020

@Simonwep Thanks for taking the time to pop in and comment. I will comment more in depth on your own site. For the benefit of casual observers - passing automated tests does not make anything accessible. They only report on the things that can be tested automatically. For example they cannot report on the ability to move from A to B etc.

avatar brianteeman
brianteeman - comment - 4 Feb 2020

@Simonwep comment and suggestion added here Simonwep/pickr#11 (comment)

avatar brianteeman
brianteeman - comment - 6 Feb 2020

Closed as we have a PR for testing #27829

avatar brianteeman brianteeman - change - 6 Feb 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-02-06 11:53:18
Closed_By brianteeman
avatar brianteeman brianteeman - close - 6 Feb 2020

Add a Comment

Login with GitHub to post a comment