[#27500] - [4.0] Add missing language tag
- Closed
- 17 Jan 2020
- Medium
- Build: 4.0-dev
- # 27500
- Diff
- N6REJ:patch-1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
fix per @brianteeman for #26858
Pull Request for Issue # .
Summary of Changes
add's missing language tag
Testing Instructions
peer review
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
| Category | ⇒ | Repository |
| Labels |
Added:
?
|
||
@brianteeman done, ty.
It’s going to need more than that. The language files are getting substituted in here with JS. We’re going to need to make the Lang injected too (ltr probably fine for now as doubt the template has support for rtl)
There are currently at least 5 errors on that page - the missing lang tag is perhaps the least important of all
I am going to close this @N6REJ
As @wilsonge said - it requires much more code than is here etc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27500.
I am going to close this @N6REJ
As @wilsonge said - it requires much more code than is here etc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27500.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-17 09:05:56 |
| Closed_By | ⇒ | brianteeman |
| Closed_Date | 2020-01-17 09:05:56 | ⇒ | 2020-01-17 09:05:57 |
| Closed_By | brianteeman | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @brianteeman by The JTracker Application at issues.joomla.org/joomla-cms/27500
This should be
<html lang="en-gb" dir="ltr">