Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#27479] - [4.0] Add library support to namespace mapper, other fixes

? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
11 Jan 2020

Pull Request for Issue #27459.

Summary of Changes

Refactors JNamespacePsr4Map::getNamespaces() code to be based on extension type rather than paths.
Adds library extension support to namespace mapper.
Removes empty component frontend namespaces.
Removes trailing slash from paths.

Testing Instructions

This should be tested on both Linux and Windows.

Delete libraries/autoload_psr4.php file.
Test that Joomla! still works.
Test that com_media works.
Test that System - Debug plugin works when debug is enabled.

Expected result

Works like before.

Documentation Changes Required

IDK.

avatar SharkyKZ SharkyKZ - open - 11 Jan 2020
avatar SharkyKZ SharkyKZ - change - 11 Jan 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jan 2020
Category ⇒ Libraries
avatar SharkyKZ SharkyKZ - change - 11 Jan 2020
Labels Added: ?
avatar richard67
richard67 - comment - 11 Jan 2020

@wilsonge How is this PR related to the Prepared Statements project?

avatar richard67
richard67 - comment - 11 Jan 2020

@SharkyKZ I can test later but only with Linux.

Other testers please report back if Linux or Windows was used so we later can see if both was tested sufficiently.

avatar 810 810 - test_item - 11 Jan 2020 - Tested successfully
avatar 810
810 - comment - 11 Jan 2020

I have tested this item ✅ successfully on 282c48d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27479.

avatar richard67
richard67 - comment - 11 Jan 2020

@810 Have you tested with webserver on Linux? Or Windows? Or both?

avatar 810
810 - comment - 11 Jan 2020

windows only

avatar richard67
richard67 - comment - 11 Jan 2020

@810 Thanks for reporting back. Is good to have an overview who tested on what.

avatar richard67 richard67 - test_item - 11 Jan 2020 - Tested successfully
avatar richard67
richard67 - comment - 11 Jan 2020

I have tested this item ✅ successfully on 282c48d

I've tested successfully with sebserver on Linux.

Have also compared newly created autoloader file with backup, using BeyondCompare (my favourite diff tool). A few frontent namespaces have been removed, guess these are the unused ones mentioned in the description. Frontend and backend still work fine.

Now we have each one good test on Linux and Windows. We need Would be nice to have one more test for each.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27479.

avatar richard67
richard67 - comment - 11 Jan 2020

@SharkyKZ We have 2 good tests, one for each server OS type. Shall I give RTC or do you want more tests?

avatar SharkyKZ SharkyKZ - change - 11 Jan 2020
Status Pending ⇒ Ready to Commit
avatar SharkyKZ
SharkyKZ - comment - 11 Jan 2020

Have 2 tests so setting RTC.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27479.

avatar wilsonge wilsonge - change - 21 Jan 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-01-21 11:53:54
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 21 Jan 2020
avatar wilsonge wilsonge - merge - 21 Jan 2020
avatar wilsonge
wilsonge - comment - 21 Jan 2020

Thanks!

Add a Comment

Login with GitHub to post a comment