? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 Jan 2020

This may be personal preference but I found the background on the "add module to dashboard" too "in your face".

With this PR you can now see the background pattern etc which I believe to be more accurate representation of the original design instead of the solid gray.

Simplified the PR to just replace the solid gray colour with the patterned background

check the grey background here

before

dont forget to run rnom i or node build.js --compile-css

70d06e4 10 Jan 2020 avatar brianteeman [4.0]
avatar brianteeman brianteeman - open - 10 Jan 2020
avatar brianteeman brianteeman - change - 10 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jan 2020
Category Administration Templates (admin)
avatar jwaisner jwaisner - test_item - 10 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 10 Jan 2020

I have tested this item successfully on 70d06e4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27468.

avatar jwaisner
jwaisner - comment - 10 Jan 2020

I agree with the subtle approach versus the harsh white.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27468.

avatar richard67
richard67 - comment - 11 Jan 2020

I disagree with same color as background. Ok, the white is really too bright. But there should be some change beside the "+" disappearing when you hover it so you can see something is activated which you can click or tip on. Maybe a grey lighter than the background would be good?

avatar infograf768
infograf768 - comment - 11 Jan 2020
avatar Fedik
Fedik - comment - 11 Jan 2020

I am not fun of both: not original, and not suggested.
tbh, the big plus icon that crosses with text looks to me as a bug. Would be cool to find a better design idea for it.

avatar richard67
richard67 - comment - 11 Jan 2020

Yes, original is also not nice. But I have no idea right now what would be optimal.

avatar Fedik
Fedik - comment - 11 Jan 2020

Maybe like this, with small "plus" and without "background fade"?
screen 2020-01-11 12 54 56 807x166

avatar infograf768
infograf768 - comment - 11 Jan 2020

Another possibility
dashboard

avatar Fedik
Fedik - comment - 11 Jan 2020

one more idea :)
screen 2020-01-11 14 28 59 1597x271

avatar HLeithner
HLeithner - comment - 11 Jan 2020

I would like to get rid of this button and move it to a position out of the grid. One position could be in the cogs of an existing module and only the normal button if no module exists.
image

avatar brianteeman
brianteeman - comment - 11 Jan 2020

I definitely would not put it there as it would not be logical

avatar HLeithner
HLeithner - comment - 11 Jan 2020

I definitely would not put it there as it would not be logical

I would prefer another position too

avatar brianteeman
brianteeman - comment - 11 Jan 2020

The suggestion here maintains the objectives of the original design

avatar HLeithner
HLeithner - comment - 11 Jan 2020

Only my opinion, it just looks unfinished if you always have a add more area that looks like a module.

avatar brianteeman
brianteeman - comment - 11 Jan 2020

I believe that was the designers intention

avatar infograf768
infograf768 - comment - 12 Jan 2020

@HLeithner
Your proposal would not work as we can unpublish some dashboard modules.

Screen Shot 2020-01-12 at 08 29 19

avatar Fedik
Fedik - comment - 12 Jan 2020

The button at bottom is good and intuitive, except its styling ?

avatar N6REJ
N6REJ - comment - 12 Jan 2020

bs convention is for lighten/darken to be 10%

avatar HLeithner
HLeithner - comment - 13 Jan 2020

I don't say that my solution is good ;-)
I only hate this big Add button that looks like a module and I can't remove it.

Giving this to a customer looks like I forgot something. And to be honest the use case for this buttons is more or less after installation and configuration afterwards you it's really unlikely that you add another module.

Also if you create the perfect dashboard and want to use the full space you always have a scrollbar...

But I don't want to discuss this any longer, it is what it is.

avatar chmst
chmst - comment - 14 Jan 2020

Do we need the + icon? In general we have a + OR the word "Add ..." not both.
If there is no +, then a 10% lightening would be sufficient and is not so "in your face".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27468.
avatar brianteeman
brianteeman - comment - 14 Jan 2020

That was the design the designer created and tbh facebook people seem to like useless wizzbang stuff like this.

Removing it is not part of this PR. I was just fixing the background to be closer to the original design

avatar brianteeman brianteeman - change - 26 Jan 2020
Labels Added: ?
avatar brianteeman brianteeman - change - 26 Jan 2020
The description was changed
avatar brianteeman brianteeman - edited - 26 Jan 2020
avatar brianteeman
brianteeman - comment - 26 Jan 2020

simplified the pr so that it is super simple and an obvious merge

avatar brianteeman brianteeman - change - 26 Jan 2020
The description was changed
avatar brianteeman brianteeman - edited - 26 Jan 2020
avatar brianteeman brianteeman - change - 31 Jan 2020
Title
[4.0] add module to dashboard background
[4.0]Simplified - add module to dashboard background
avatar brianteeman brianteeman - edited - 31 Jan 2020
avatar Quy Quy - test_item - 3 Feb 2020 - Tested successfully
avatar Quy
Quy - comment - 3 Feb 2020

I have tested this item successfully on abb5d61


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27468.

avatar jwaisner jwaisner - test_item - 5 Feb 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 5 Feb 2020

I have tested this item successfully on abb5d61


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27468.

avatar alikon alikon - change - 5 Feb 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 5 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27468.

avatar rdeutz rdeutz - change - 5 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-05 17:46:44
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 5 Feb 2020
avatar rdeutz rdeutz - merge - 5 Feb 2020
avatar brianteeman
brianteeman - comment - 5 Feb 2020

Thanks all

Add a Comment

Login with GitHub to post a comment