Feeling Lucky
?
[#2744] - Fix html tag check in content
- Closed
- 9 Apr 2014
- Medium
- Build: master
- # 2744
- Diff
- nonumber:patch-2
- Error This pull request is targeted at the master branch. Pull requests should no longer be merged to master.
User tests: Successful: Unsuccessful:
Not sure why tags in the content are not allowed in this method, but the way it checks for them is naff.
- It doesn't take into account any new html5 tags
- It only checks for a possible space after the tag name, not for any other type of whitespace, like:
<a
href="...">
The solution is to simply check for any possible tag using regular expressions. Is a lot faster too than checking for every single tag of that long array separately.
It now checks for occurrences of:<[any letter][0 or more letters or numbers]>
or:<[any letter][0 or more letters or numbers][space or other whitespace]
| Labels |
Added:
?
|
||
| Description | <p>Not sure why tags in the content are not allowed in this method, but the way it checks for them is naff.</p> <ul> <li>It doesn't take into account any new html5 tags</li> <li>It only checks for a possible space after the tag name, not for any other type of whitespace, like: <code> <a href="..."> </code> </li> </ul><p>The solution is to simply check for any possible tag using regular expressions. Is a lot faster too than checking for every single tag of that long array separately.</p> <p>It now checks for occurrences of:<br><code><[any letter][0 or more letters or numbers]></code><br> or:<br><code><[any letter][0 or more letters or numbers][space or other whitespace][whatever characters]></code></p> | ⇒ | <p>Not sure why tags in the content are not allowed in this method, but the way it checks for them is naff.</p> <ul> <li>It doesn't take into account any new html5 tags</li> <li>It only checks for a possible space after the tag name, not for any other type of whitespace, like:</li> </ul><pre><code><a href="..."> </code></pre> <p>The solution is to simply check for any possible tag using regular expressions. Is a lot faster too than checking for every single tag of that long array separately.</p> <p>It now checks for occurrences of:<br><code><[any letter][0 or more letters or numbers]></code><br> or:<br><code><[any letter][0 or more letters or numbers][space or other whitespace]</code></p> |
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-04-09 10:19:19 |
Too old. Code lost.