[#27432] - Use absolute URLs in action logs
- Fixed in Code Base
- 22 Jan 2020
- Medium
- Build: staging
- # 27432
- Diff
- SharkyKZ:patch-3
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Fixes #27431.
Summary of Changes
Use absolute URLs for links in action log emails.
Testing Instructions
Make sure Force HTTPS option in Global Configuration is disabled.
As super admin, edit your profile. Enable Send notifications for User Actions Log option.
Perform a loggable action (e.g. edit an article).
Try clicking the links in the action notification email.
Expected result
Links take you to your Joomla! website.
Actual result
Links don't work.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Rel_Number | ⇒ | 27431 | |
| Relation Type | ⇒ | Pull Request for |
| Labels |
Added:
?
|
||
The issue is reproducible only when Force HTTPS is disabled.
The issue is reproducible only when
Force HTTPSis disabled.
I opened the administrator panel via http:// (no SSL) and Force HTTPS is set to None.
However, the issue occurs.
Then I opened the back-end via https:// and set Force HTTPS to Entire site.
The email is consists of correct URLs and there is no issue described above.
The conclusion: the problem could happen with the sites without SSL...
Yes, the issue occurs when Force HTTPS is set to None (i.e. disabled).
Thanks for the PR!
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27432.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27432.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-22 10:29:04 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
"Make sure Force HTTPS option in Global Configuration is disabled."
Why so? There are a lot of websites with SSL.