[#27429] - [4.2] [DRAFT] Global Delete Trash - New Feature
- Closed
- 30 May 2022
- Medium
- Build: 4.0-dev
- # 27429
- Diff
- brianteeman:trash
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
It has been requested several times that there was a single place where you could go and "empty the trash" for all components.
This new component is based on com_checkin
At this stage
[ ] I am sure the code in the model can be improved
[ ] What should the default permissions be or should it be hard coded restricted to super users only like joomlaupdate is
[ ] To do - add a quickicon on the home dashboard ?
testing
Apply patch and then discover the component
You will then find it in the Maintenance section of the system dashboard
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Language & Strings |
| Title |
|
||||||
| Labels |
Added:
?
?
|
||
| Category | Administration com_menus Language & Strings | ⇒ | Administration com_menus Language & Strings Libraries |
I have tested this item
Everything functions as expected after being added to list as core extension.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27429.
I'm not sure if com_checkin is a good example. At least if we ever intend to support tables with custom column names. We have some ways of mapping column names to "standard" column names (Joomla\CMS\Table\Table::setColumnAlias() method or the UCM field mappings) but none of that works if we just run through all database tables.
Great new feature ... I think it HAS to go into 4.0 ... so I hope it will be ready before beta.
@brianteeman Is it still draft/WiP? Or is it (beside PHPCS) ready for test? Let us know please when we shall test.
it is a draft - as in there are bits not done such as install sql AND the questions in the original post. I am confident that the code works just dont know if it is something people think is a good idea etc
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27429.
@richard67 Can you please give this one a test?
@brianteeman I think it is a good idea. Now how to handle the install SQL is beyond me.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27429.
@jwaisner As far as I understood @brianteeman this PR is still a draft and not ready. And it is late now here in my time zone and I have to work tomorrow, so right I won't test for sure.
The idea of a global trash is good, but using com_checkin as base is not the best approach. Sharky already mentioned the this component loads all tables and tries to figure out if there is a trash able item or not.
The right way would be that each component has to register for the global trash.
The right way would be that each component has to register for the global trash.
There is perfect engineering and there is working engineering
Well, this isn't working. Items should be deleted through the model to make sure all associated data is deleted and proper plugin events are triggered.
Can you please provide a specific example of where its not working
Everywhere. None of associated data is deleted because none of the code meant for handling item deletion is being executed this way. Examples of remaining loose data include Asset record (in #__assets table), Language Associations, Custom Fields data, Tag mappings, Content History and 3rd party plugin data.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-24 09:39:05 |
| Closed_By | ⇒ | brianteeman |
forgive me for trying to be constructive and add a requested feature
You don't need to apologize. It's a good feature but it needs a different approach. I, for one, don't know what that approach would be
| Status | Closed | ⇒ | New |
| Closed_Date | 2020-01-24 09:39:05 | ⇒ | |
| Closed_By | brianteeman | ⇒ | |
| Labels |
Added:
Language Change
Removed: ? ? |
||
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Title |
|
||||||
re-oponed in draft status as a reminder to myself to work on this
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-05-30 15:30:47 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
Removed: ? |
||
Closed - no interest
I have tested this item✅ successfully on a6a6e3b
component functions. trashed objects from all com_ tables. Used component to delete trashed items across the entire site.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27429.