[#27418] - [4.0] Load webcomponents with asset manager
- Fixed in Code Base
- 7 Jan 2020
- Medium
- Build: 4.0-dev
- # 27418
- Diff
- Fedik:asset-wc2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
This will load webcomponents with asset manager.
Testing Instructions
Apply patch run npm install
Click around, try create/edit content, all should work as before.
Expected result
Everything works
Actual result
Everything works
Documentation Changes Required
Need to update Asset documentation to describe how to add webcomponent to it.
ping @wilsonge
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_categories com_config com_fields com_media com_modules Repository NPM Change Layout Libraries |
@Fedik are you also covering this hidden functionality:
joomla-cms/libraries/src/HTML/HTMLHelper.php
Line 765 in 543246a
nope, it not hidden now
it need to explicitly call to the style if webcomponent have a style, eg:
joomla-cms/layouts/joomla/form/field/color/simple.php
Lines 55 to 59 in 0afe53a
much better
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-07 10:25:14 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
NPM Resource Changed
?
|
||
Thanks!
Thanks!
the doc for this part https://docs.joomla.org/J4.x:Web_Assets#Working_with_a_web_component
I have tested this item✅ successfully on 0afe53a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27418.