[#27406] - [4.0] Template: cassiopeia fix card border color to support dark mode (flag)
- Fixed in Code Base
- 4 Aug 2020
- Low
- Build: 4.0-dev
- # 27406
- Diff
- 810:patch-1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
When you enable dark mode (flag setting) on the browser, all websites are showed as dark.
But on the card the color was to white and wasn't showed correctly.
Summary of Changes
card border color
Testing Instructions
edge://flags
chrome://flags
enable Force Dark Mode for Web Contents
Expected result
Actual result
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
Many things are getting changed by the browser (the feature itself), only we need to change some conflicts. I didn't found any other issue, then the top logo banner. But i need to check more conflicts.
Like this issue on github:
| Labels |
Added:
?
|
||
i don't see any other issues, so we can merge this one.
jwaisner
- | Priority | Medium | ⇒ | Low |
I have tested this item
The white borders still exist.
I was using Microsoft Edge Version 84.0.522.52
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27406.
I have tested this item
Works as expected, but your testing instructions are incomplete.
Before testing the change you need to run npm run build:css or the changes won't take place (obviously).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27406.
I have tested this item
Works as expected on the frontend but changes did not apply in the backend.
as mentioned before, you have to run npm run build:css before testing else it won't show any differences.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27406.
@david0296 Did you run the npm run build:css ?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-04 14:05:22 |
| Closed_By | ⇒ | roland-d |
| Category | Front End Templates (site) | ⇒ | Front End Templates (site) NPM Change |
just going from your screenshot
If the card outline needs to be changed then so does the input border as seen in the login module and many more places.
I am not against updating to make it compatible with the dark mode flag but its better to do it all at once in a consistent manner and not piecemeal