You need to update templateDetails.xml as well to list the new file

And I am guessing that libraries\src\Document\OpensearchDocument.php also needs updating to support the svg

The code should be refactored and not only copy paste the ico code if we add svg we could png,gif and jpg too (not sure if it's in the specs but all browsers supports them)

As far as I understand the use of the mimetype is not recommended for current browsers. And anyway you have the wrong mimetypes

https://bitsofco.de/all-about-favicons-and-touch-icons/

Safari and firefox is already supporting it. Chrome is supported on Feb 4.

I believe there will be no joomla 4.0 beta before that date, so its save to add it now.

Thats not what I meant. The mimetype you have set in the code are not correct and its not recommended to use it anyway

could you tell me which mimetype is wrong, for my knowledge they are correct.

from the demo page (source: chrome)

<link href="favicon.ico" rel="shortcut icon" type="image/vnd.microsoft.icon">
<link rel="icon" type="image/svg+xml" href="favicon.svg"/>
<link rel="alternate icon" type="image/png" href="favicon.png"/>

sorry looks like I was looking at it before you updated the types

Seems excessive on each page load to do 12 file checks/disk access.

Seems excessive on each page load to do 12 file checks/disk access.

I wrote already a PR for this https://github.com/810/joomla-cms/pull/1

still error on api test:

Body: <br />
--
206 | <b>Warning</b>:  dir(/tests/www/test-install/api/templates/system): failed to open dir: No such file or directory in <b>/tests/www/test-install/libraries/src/Document/HtmlDocument.php</b> on line <b>695</b><br />
207 | Error: Call to a member function read() on boolean: Could not match accept header

https://support.google.com/webmasters/answer/9290858

Your favicon should be a multiple of 48px square, for example: 48x48px, 96x96px, 144x144px and so on. SVG files, of course, do not have a specific size. Any valid favicon format is supported. Google will rescale your image to 16x16px for use in search results, so make sure that it looks good at that resolution. Note: do not provide a 16x16px favicon.

RTC ?

Ok chrome has released the new version with support, we can now set it to rtc

My concern is that the same file check is done with each page load. Would it be better to have a setting to select which format(s) have been installed?

@wilsonge Is my concern valid?

First thanks for the prod here :)

Where would you put the setting? I mean I agree that it's not ideal to loop through these things on each page load. but at the same time I'm not sure exactly where we could put the setting where it's logical.

If someone uploads an SVG for example - they put it in the active template directory. So logical is template component global config. But if they have multiple templates then it may not be the same file (or extension). But only the template can control it's own settings.

To me it's probably something we should cache. But I dunno if we have a mechanism within the cache driver to store specific pieces of information like this.

Hello everyone, I wonder if this plugin is useful for favicons in Joomla, if so I am happy to contribute it as a PR.
(Before surely the code would need to be adapted to Joomla 4)

https://github.com/coolcat-creations/DBfavicon

Adds favicons in different sizes + possibility to enable disable

Adds apple-touch-icons in different sizes + possibility to enable disable

Adds android-icons in different sizes
    Link behaviour
    Force screen orientation
    Customize Colour of task bar
    generates and adds manifest.json for android
    Customize Colour of task bar
    possibility to enable disable

Adds Windows tiles
    Set up tile colour
    Adds browserconfig.xml file to root folder for mstiles
    possibility to enable disable

Hello everyone, I wonder if this plugin is useful for favicons in Joomla, if so I am happy to contribute it as a PR.
(Before surely the code would need to be adapted to Joomla 4)

https://github.com/coolcat-creations/DBfavicon

Adds favicons in different sizes + possibility to enable disable

Adds apple-touch-icons in different sizes + possibility to enable disable

Adds android-icons in different sizes
    Link behaviour
    Force screen orientation
    Customize Colour of task bar
    generates and adds manifest.json for android
    Customize Colour of task bar
    possibility to enable disable

Adds Windows tiles
    Set up tile colour
    Adds browserconfig.xml file to root folder for mstiles
    possibility to enable disable

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27393.

I think a plugin would be the wrong approach for a native integration. But integrating this directly into HtmlDocument and in the template style part of joomla. This would allow every template to use it without knowing too much about the necessary settings.

One concern could be that this is a really fast moving target. My feeling is that ever 2 month there is a new property or resolution or other setting and two other get deprecated.

But I think this should a an own issue not not discussed as part of this pr.

I think a plugin would be the wrong approach for a native integration. But integrating this directly into HtmlDocument and in the template style part of joomla. This would allow every template to use it without knowing too much about the necessary settings.

One concern could be that this is a really fast moving target. My feeling is that ever 2 month there is a new property or resolution or other setting and two other get deprecated.

But I think this should a an own issue not not discussed as part of this pr.

This code at least did not change since 4 Years. If you can help me how to implement it properly I am happy to contribute this to the core.

This code at least did not change since 4 Years.

@HLeithner is talking about new formats like using svg and other formats being dropped
https://www.emergeinteractive.com/insights/detail/the-essentials-of-favicons/

This code at least did not change since 4 Years.

@HLeithner is talking about new formats like using svg and other formats being dropped
https://www.emergeinteractive.com/insights/detail/the-essentials-of-favicons/

Yes and what I meant is that this plugin already has some more modern features than Joomla has now. Before implementing svg here we should know how to handle svg in Joomla at all.

I have tested this item ✅ successfully on 173ea48

Verified in Chrome, Safari, Mozilla

I have tested this item ✅ successfully on 173ea48

Verified in Chrome, Safari, Mozilla

@Quy any reason why you closed this one?