User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Repository NPM Change |
The order that the css is loaded is a different issue.
float: none is completely wrong for a desktop site and that is what this fixes.
(we really should not have a template-rtl.css)
It HAS to switch to none when the window is reduced. This pr alone breaks the whole display on mobile. One can’t solve an issue while creating another.
Both situations have to be solved together...
well before this PR the desktop was broken. I will work on fixing the mobile now
Labels |
Added:
NPM Resource Changed
?
|
Category | Repository NPM Change | ⇒ | Administration Templates (admin) Repository NPM Change |
until someone works out the css ordering this PR now works correctly on mobile as well
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-06 15:33:27 |
Closed_By | ⇒ | infograf768 |
That is not enough.
As I said in the other pr for searchtools, we have an issue when reducing the window as we should get float none but the template rtl css does not load after the system css in that case.