NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
30 Dec 2019

see screenshots for changes

If we wait for an expert to fix it then it will never happen

On pages where we still have an admin/site select such as /administrator/index.php?option=com_languages&view=installed&client=1 there is an error in the RTL css that forces it to be full width

Before

image

After

image

avatar brianteeman brianteeman - open - 30 Dec 2019
avatar brianteeman brianteeman - change - 30 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Dec 2019
Category Repository NPM Change
avatar infograf768
infograf768 - comment - 30 Dec 2019

That is not enough.
As I said in the other pr for searchtools, we have an issue when reducing the window as we should get float none but the template rtl css does not load after the system css in that case.

avatar brianteeman
brianteeman - comment - 30 Dec 2019

The order that the css is loaded is a different issue.
float: none is completely wrong for a desktop site and that is what this fixes.

(we really should not have a template-rtl.css)

avatar infograf768
infograf768 - comment - 30 Dec 2019

It HAS to switch to none when the window is reduced. This pr alone breaks the whole display on mobile. One can’t solve an issue while creating another.
Both situations have to be solved together...

avatar brianteeman
brianteeman - comment - 30 Dec 2019

well before this PR the desktop was broken. I will work on fixing the mobile now

avatar brianteeman brianteeman - change - 30 Dec 2019
Labels Added: NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Dec 2019
Category Repository NPM Change Administration Templates (admin) Repository NPM Change
avatar brianteeman
brianteeman - comment - 30 Dec 2019

until someone works out the css ordering this PR now works correctly on mobile as well

avatar infograf768
infograf768 - comment - 2 Jan 2020

See discussion in #27384
After this is solved, we may have to totally refactor the css for searchtools.
I also informed maintainers about the issue.

Note: yes, the change to mobile with !important works in a similar way as ltr now.

avatar infograf768
infograf768 - comment - 6 Jan 2020

Closing as the changes here are included in #27416

avatar infograf768 infograf768 - change - 6 Jan 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-01-06 15:33:27
Closed_By infograf768
avatar infograf768 infograf768 - close - 6 Jan 2020

Add a Comment

Login with GitHub to post a comment