? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
30 Dec 2019

Removes the message to say that the plugin is enabled etc. Just keep the message that says the plugin is not enabled

Pull Request for Issue #27378
Prevents this from happening
redirect

avatar brianteeman brianteeman - open - 30 Dec 2019
avatar brianteeman brianteeman - change - 30 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Dec 2019
Category Administration com_redirect Language & Strings
avatar infograf768
infograf768 - comment - 30 Dec 2019

This kills the alert for the disabled Collect URLs option.

Screen Shot 2019-12-30 at 12 12 31

Please re-add that single one.

avatar brianteeman
brianteeman - comment - 30 Dec 2019

No. for the same reason as the plugin enabled.

avatar infograf768 infograf768 - test_item - 30 Dec 2019 - Tested unsuccessfully
avatar infograf768
infograf768 - comment - 30 Dec 2019

I have tested this item ? unsuccessfully on 8db9823

Setting as unsuccessful as we need an alert when the option is disabled, evidently not when it is enabled. Similar to this patch but only showing when the plugin is enabled.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27380.
avatar brianteeman
brianteeman - comment - 30 Dec 2019

Why do we need it? Where else do we have a similar alert?

avatar infograf768
infograf768 - comment - 30 Dec 2019

This was an improvement that was welcomed in former versions. Why killing it? Why lose what works and is useful to the users? Just display it when the plugin is enabled and the option is not set and we are done.
Not everyone will know or remember that option which is essential for this component specifically.

avatar brianteeman
brianteeman - comment - 30 Dec 2019

You can make the same argument for lots of things - it is a useless argument. You don't agree - thats fine. You dont have to agree with everything

avatar HLeithner
HLeithner - comment - 30 Dec 2019

I also mentioned it's not useless but it shouldn't be an alert.

A (constant) section about the component like in j3 which such information would be great.

avatar infograf768
infograf768 - comment - 30 Dec 2019

A (constant) section about the component like in j3 which such information would be great.

Maybe where we display No Matching Results ?

avatar brianteeman
brianteeman - comment - 30 Dec 2019

@HLeithner are you going to start displaying similar messages then for components where fields are not enabled etc
@infograf768 No because you may have results.

avatar infograf768
infograf768 - comment - 30 Dec 2019

No because you may have results.

That is not an issue. We can create a specific method in the model, get its result in template and create a specific div to display it.

avatar HLeithner
HLeithner - comment - 30 Dec 2019

@brianteeman

@HLeithner are you going to start displaying similar messages then for components where fields are not enabled etc

Only where it makes sense, we have the same thing in smart search with the search plugins.

image

maybe there are more components or view were a static message makes sense.

avatar brianteeman
brianteeman - comment - 30 Dec 2019

I see that smart search has the same problem with the constantly repeating alert.

I will look at the static message idea in the morning

Something like this ?

image

avatar HLeithner
HLeithner - comment - 30 Dec 2019

Yes something like this

avatar brianteeman
brianteeman - comment - 30 Dec 2019

easy enough

avatar brianteeman
brianteeman - comment - 30 Dec 2019

closing for now - will either reopen with the static message for com_redirect and com_finder or will create a new pr

avatar brianteeman brianteeman - change - 30 Dec 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-12-30 23:51:30
Closed_By brianteeman
Labels Added: ? ?
avatar brianteeman brianteeman - close - 30 Dec 2019

Add a Comment

Login with GitHub to post a comment