? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
29 Dec 2019

On a multilingual site with more than two languages the language indicators have a div for displaying the tooltip

The way the id for the div was generated it might not be unique. This PR ensures that it is unique.

Applied to menus, categories, content, contacts, newsfeeds (don't think there is anywhere else?)

image

avatar brianteeman brianteeman - open - 29 Dec 2019
avatar brianteeman brianteeman - change - 29 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Dec 2019
Category Administration com_categories com_contact com_content com_menus com_newsfeeds
avatar brianteeman brianteeman - change - 29 Dec 2019
Labels Added: ?
avatar Quy Quy - test_item - 29 Dec 2019 - Tested successfully
avatar Quy
Quy - comment - 29 Dec 2019

I have tested this item successfully on d5faf05


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27370.

avatar astridx astridx - test_item - 3 Jan 2020 - Tested successfully
avatar astridx
astridx - comment - 3 Jan 2020

I have tested this item successfully on ab43a1e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27370.

avatar astridx astridx - test_item - 3 Jan 2020 - Tested successfully
avatar astridx
astridx - comment - 3 Jan 2020

I did the following:

  1. I run git fetch origin pull/27370/head:associationdiv
  2. After that I installed French and German language and activated the language filter plugin.
  3. I created a French a German and an English article and set up the associations.
  4. I debug and checked the id here.
  5. I checked out the branch associationdiv
  6. I run debugger again an see, that the ID here was correctly changed.
avatar brianteeman
brianteeman - comment - 3 Jan 2020

Good spot @HLeithner I have applied those changes

avatar HLeithner
HLeithner - comment - 3 Jan 2020

@brianteeman you missed a button^^

avatar brianteeman
brianteeman - comment - 4 Jan 2020

@HLeithner I was on my phone :(

avatar Quy Quy - test_item - 4 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 4 Jan 2020

I have tested this item successfully on 6d21ea2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27370.

avatar astridx astridx - test_item - 4 Jan 2020 - Tested successfully
avatar astridx
astridx - comment - 4 Jan 2020

I have tested this item successfully on 6d21ea2

I did 'git pull origin pull/27370/head:associationdiv' and repeated my test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27370.

avatar HLeithner HLeithner - change - 4 Jan 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-04 15:32:46
Closed_By HLeithner
avatar HLeithner HLeithner - close - 4 Jan 2020
avatar HLeithner HLeithner - merge - 4 Jan 2020
avatar HLeithner
HLeithner - comment - 4 Jan 2020

Thanks

avatar brianteeman
brianteeman - comment - 4 Jan 2020

Thanks

Add a Comment

Login with GitHub to post a comment