? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Dec 2019

Inspired by the alternate template proposal which is going nowhere this changes the new module page from a list to a card view.

It is massively due some css love and care

testing

dont forget to nmp i for the new css

before

image

after

image

avatar brianteeman brianteeman - open - 28 Dec 2019
avatar brianteeman brianteeman - change - 28 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Dec 2019
Category Administration com_modules Language & Strings Templates (admin)
avatar Fedik
Fedik - comment - 28 Dec 2019

I have two conflicting feelings:

  • it looks nicer
  • it harder to find needed module
avatar HLeithner
HLeithner - comment - 28 Dec 2019

I have the same feeling as Fedir

avatar brianteeman
brianteeman - comment - 28 Dec 2019

Note: the ordering is the same as before

avatar Fedik
Fedik - comment - 29 Dec 2019

Couple suggestions for usability improvement:

  • About ordering: it better to make it "row flow", instead of "column flow", then I always know that upper part of alphabet are top, and bottom part of alphabet are bottom. Like now it hard and will be harder with many more modules.
  • Each row and each cell in the row should have the same height, this will prevent "eye jumping" up and down while looking for needed module. It should be "perfect grid" :)
  • Because of needing the same height, the title of cell need to be 1 row (long titles just cut down with overflow), and the description need to reduce in size (2-3 row) and also cut to keep the same height. Perfectly the full description and full title should be expanded "on hover". You know this nice effect in some shops, when you hover on product in grid overview you get expanded cell with product description? :) (something like that https://youtu.be/wHwyDt7bXDY?t=12, sorry I did not found a code example on quick search, technically it just an extra <div> with position absolute, that gets bigger on hover)
  • Whole cell need to be "clickable" (or better to call it "selectable"), so I quickly can select needed module just by clicking on it without searching for a little "select" button. With this maybe even can remove a "select" button to save some space.
avatar brianteeman
brianteeman - comment - 29 Dec 2019

Couple suggestions for usability improvement:

  • About ordering: it better to make it "row flow", instead of "column flow", then I always know that upper part of alphabet are top, and bottom part of alphabet are bottom. Like now it hard and will be harder with many more modules.

Agree but I don't know how :(

  • Each row and each cell in the row should have the same height, this will prevent "eye jumping" up and down while looking for needed module. It should be "perfect grid" :)

Change to above should resolve that

  • Because of needing the same height, the title of cell need to be 1 row (long titles just cut down with overflow), and the description need to reduce in size (2-3 row) and also cut to keep the same height. Perfectly the full description and full title should be expanded "on hover". You know this nice effect in some shops, when you hover on product in grid overview you get expanded cell with product description? :) (something like that https://youtu.be/wHwyDt7bXDY?t=12, sorry I did not found a code example on quick search, technically it just an extra <div> with position absolute, that gets bigger on hover)

Not sure that will be needed after above

  • Whole cell need to be "clickable" (or better to call it "selectable"), so I quickly can select needed module just by clicking on it without searching for a little "select" button. With this maybe even can remove a "select" button to save some space.

I am not a fan of that. It's an accessibility nightmare

avatar Fedik
Fedik - comment - 29 Dec 2019

It a bit more code than column-count: 4; ;)
column-count not allow to change "flow".
Can try bootstrap grid if it enabled in admin template,
or look for use CSS Flex

.card-columns{
  display:flex;
  flex-flow: row;
  flex-wrap: wrap;
}
.card-columns>.card{
  flex: 1 1 250px;
}

or CSS grid

.card-columns{
  display: grid;
  grid-template-columns: 1fr, 1fr, 1fr, 1fr;
}

Not sure that will be needed after above

You are right, however I would still limit the description, it will looks more consistent when 1 module has 2 word(row) in description, and another 20 words. But can skip it for now, maybe later someone add.

I am not a fan of that. It's an accessibility nightmare

I cannot say here much :)
It just wrap a whole card in to <a> (maybe with title) and it will be like a list of "buttons", is that still bad? :)
But this will save really much space, and will make a "select action" faster.

avatar brianteeman brianteeman - change - 29 Dec 2019
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 29 Dec 2019

I switched it to use card-deck etc

The direction is not left to right in rows not columns
Each row is the same height

We are already truncating the module description if it is too long ;)

image

avatar Fedik
Fedik - comment - 29 Dec 2019

that looks much better :)

We are already truncating the module description if it is too long ;)

I have missed that :)

avatar ghazal ghazal - test_item - 29 Dec 2019 - Tested successfully
avatar ghazal
ghazal - comment - 29 Dec 2019

I have tested this item successfully on f736ad3

Great job. Hope it will be accepted.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27361.

avatar TobsBobs TobsBobs - test_item - 29 Dec 2019 - Tested successfully
avatar TobsBobs
TobsBobs - comment - 29 Dec 2019

I have tested this item successfully on f736ad3

Looka nice!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27361.

avatar HLeithner
HLeithner - comment - 29 Dec 2019

Small question shouldn't the 'select' link look more like a button? It looks a bit lost

avatar brianteeman
brianteeman - comment - 29 Dec 2019

@HLeithner thats why I wrote

It is massively due some css love and care

and why this is an RFC and not a full PR

avatar HLeithner
HLeithner - comment - 29 Dec 2019

@HLeithner thats why I wrote

It is massively due some css love and care

and why this is an RFC and not a full PR

true, so a button layout would be cool in my opinion ;-)

avatar brianteeman
brianteeman - comment - 29 Dec 2019

Sorry - i should have been clearer - can someone help with that css

I will give it a try but it's really not my area

avatar Fedik
Fedik - comment - 30 Dec 2019

Maybe try add class btn btn-primary btn-sm to a button:
screen1

or even drop whole card-footer section, and do the button directly after card-body as on first example there https://getbootstrap.com/docs/4.0/components/card/ (button class btn btn-primary, and remove mr-2) :
screen2

or lighter (button class btn btn-light) :
screen3

upd: maybe can extend text to more verbose "Select this module", but not important.

avatar brianteeman
brianteeman - comment - 30 Dec 2019

Thanks
image

avatar TobsBobs
TobsBobs - comment - 30 Dec 2019

Should I retest this PR or should I wait because this is a RFC?

avatar Fedik
Fedik - comment - 30 Dec 2019

hm hm, not really, it not "clickable" ;)

Remove whole section:

<div class="card-footer btn btn-primary">
 ...
</div>

And add only:

<a href="<?php echo Route::_($link); ?>" class="btn btn-primary <?php echo $function ? ' select-link" data-function="' . $this->escape($function) : ''; ?>" aria-label="<?php echo Text::sprintf('COM_MODULES_SELECT_MODULE', $item->name); ?>">
  <?php echo Text::_('JSELECT'); ?>
</a>

It will make whole footer as "clickable" button

avatar brianteeman
brianteeman - comment - 30 Dec 2019

Thanks @Fedik
This is ready for testing now

avatar brianteeman brianteeman - change - 30 Dec 2019
Title
[4.0] RFC Select Modules page
[4.0] Select Modules page
avatar brianteeman brianteeman - edited - 30 Dec 2019
avatar brianteeman brianteeman - change - 30 Dec 2019
The description was changed
avatar brianteeman brianteeman - edited - 30 Dec 2019
avatar brianteeman brianteeman - change - 30 Dec 2019
The description was changed
avatar brianteeman brianteeman - edited - 30 Dec 2019
avatar brianteeman
brianteeman - comment - 30 Dec 2019

I have updated the original post and title

avatar Quy
Quy - comment - 31 Dec 2019

Visually I like, however, it requires 2 wheel scrolls to see the entire list and to look for a module, your eyes scan across, diagonal, across, diagonal, and so on vs just up and down.

avatar infograf768
infograf768 - comment - 1 Jan 2020

I agree with @Quy on this one. It is much easier to scan up and down.

avatar brianteeman
brianteeman - comment - 2 Jan 2020

Thats just for scanning titles. When you are also scanning the descriptions it is proven that a shorter line length is more effective.

avatar HLeithner
HLeithner - comment - 2 Jan 2020

In the end I use strg+f to find the module^^

avatar Fedik
Fedik - comment - 2 Jan 2020

Maybe really try to drop the select button? it will allow to display more rows at once:
2

can be something like (need to test):

<div class="card mb-4">
<a href="<?php echo Route::_($link); ?>" class="<?php echo $function ? ' select-link" data-function="' . $this->escape($function) : ''; ?>" aria-label="<?php echo Text::sprintf('COM_MODULES_SELECT_MODULE', $item->name); ?>">
  <div class="card-header"> ... </div>
  <div class="card-body"> ... </div> 
</a>
</div>

and css

#new-modules-list .card>a{
 text-decoration: none;
 color: inherit;
}

I cannot say about an accessibility,
Maybe can just try to test?

avatar brianteeman
brianteeman - comment - 2 Jan 2020

I am going to stick by the proposal here.

avatar Quy
Quy - comment - 3 Jan 2020

Minor styling when in a modal.

add-module

I prefer the current/list format because I can just focus on the module names and look to the right for the description. With the new format, I feel that my eyes are scanning all over the place.

avatar jwaisner jwaisner - test_item - 3 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 3 Jan 2020

I have tested this item successfully on 169ab46


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27361.

avatar jwaisner
jwaisner - comment - 14 Jan 2020

@TobsBobs @ghazal Can you please test the latest again as changes have been made?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27361.

avatar brianteeman
brianteeman - comment - 6 Feb 2020

I really think this is a major ui improvement

avatar infograf768
infograf768 - comment - 7 Feb 2020

I keep with my comment above: this forces to scroll a lot and read from one side of the screen to the other until the specific module is found.
What we have may not be as "beautiful" but it is certainly easier to work with.

avatar brianteeman
brianteeman - comment - 7 Feb 2020

based on comments elsewhere beautiful is what people want

avatar richard67
richard67 - comment - 9 Feb 2020

To be honest I also prefer the list style like it is without this PR. But maybe I'm just a bit old fashioned.

avatar wilsonge
wilsonge - comment - 10 Mar 2020

@brianteeman I'd be interested in resurrecting this if you're happy to spend the time making it work with the new redesign?

avatar brianteeman
brianteeman - comment - 10 Mar 2020

I am happy to do it but no one here seemed to like it.

avatar brianteeman
brianteeman - comment - 10 Mar 2020

@wilsonge updated as requested

avatar sanek4life
sanek4life - comment - 11 Mar 2020

before

image

This choice may look much better if there are icons for the items, for example - Font-Awesome

avatar brianteeman
brianteeman - comment - 11 Mar 2020

Funny thing is that this is basically the same view from the other template that everyone raved about the design of.

avatar sanek4life
sanek4life - comment - 11 Mar 2020

Funny thing is that this is basically the same view from the other template that everyone raved about the design of.

I mean, something like this:

изображение

avatar wilsonge wilsonge - close - 25 Mar 2020
avatar wilsonge wilsonge - merge - 25 Mar 2020
avatar wilsonge wilsonge - change - 25 Mar 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-25 12:37:22
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 25 Mar 2020

Thanks! I think the logical next step is to have screenshots in the boxes - similar to how we do things in the templates view - but this is a good first step and also incorporates the work done by the alternative template team

avatar brianteeman
brianteeman - comment - 25 Mar 2020

Thanks @wilsonge
Not sure I agree about the screenshots but if someone wants to give a try then fine by me

Add a Comment

Login with GitHub to post a comment