[#27352] - [4.0] toggled menu flyout
- Fixed in Code Base
- 30 Dec 2019
- Medium
- Build: 4.0-dev
- # 27352
- Diff
- brianteeman:mennu
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Demo of a flyout menu as requested #27347
Now complete with accessible names for the collapsed menu items
(not added a visible text for the toggle bar just an accessible one)
Testing Instructions
npm i
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
I have tested this item
Nice.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27352.
Home Dashboard is behind the buttons and no tooltip for Toggle Menu.
| Labels |
Added:
?
|
||
I have tested this item
Even nicer now.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27352.
The Toggle Menu icon does not have a tooltip. Is it necessary?
Ok, I see, I was too fast .. will test again when ready and I have time.
| Category | Administration Templates (admin) | ⇒ | Modules Administration Templates (admin) |
Now updated with accessibility fixes
Toggle Menu still not expanding.
Not sure what you mean but
(not added a visible text for the toggle bar just an accessible one)
That's exactly what I wrote and is intentional
Also tested successfully. Thanks, Brian.
@ChrisHoefliger Could you mark your test result on the issue tracker here https://issues.joomla.org/tracker/joomla-cms/27352?
Just use the "Test this" button and then select the right test result and then submitt.
Thanks in advance.
I have tested this item
Successfully tested
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27352.
That's exactly what I wrote and is intentional
What is the reasoning behind this intention?
because it is not needed. Not everything requires visible text. what is your reason for saying it should be there
what is your reason for saying it should be there
Just a normalization with the other icons.
except it is not part of the menu
Whatever...
I have tested this item
Not sure if the toggle button should also have some flyout or not. At the one hand it doesn't belong to the menu, at the other hand it looks as if it would. At the one hand it is more or less clear that it must be a toggle button because it has the right icon for that and doesn't have a flyout, at the other hand who knows how other users think.
Finally I think the PR is good as it is, and future enhancement of the toggle button can be done with a new PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27352.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27352.
P.S.: Of course I've checked accessibility, too.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-30 23:18:24 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
Thanks
Drone mysql system test failure seems to be the usual timeout problem and so not related to this PR.