User tests: Successful: Unsuccessful:
Pull Request for Issue #27349
position
to LI elements.Status | New | ⇒ | Pending |
Category | ⇒ | com_tags Front End |
If I apply this patch in the file default_items.php (at line 101) then I get another error and the original error is still there: "Duplicate values for itemListElement.url are not allowed."
I can't reproduce your find with core Joomla.
Do you use an template override for file components/com_tags/views/tag/tmpl/default_items.php ?
You should not for testing this pr.
Did you follow the testing instructions exactly? Same menu item type and so on?
If not: What are the differences between your menu item and my screenshot above?
Can you provide the link to your page where I can see the error?
I did have an override.. (very embarrassing sorry)
Your patch absolutely did work!
@alikon
Tested yesterday after removing (temporary) my .htaccess (otherwise not possible) :-)
Just an idea: Code review shows:
<li class="cat-list-row0 clearfix" itemprop="itemListElement" itemscope itemtype="https://schema.org/ListItem"> <h3 itemprop="name"> <a href="/hstompers/index.php/testg" itemprop="url"> TestG </a> </h3>
your line is without /menue ?
<a href="/index.php/" itemprop="url">
Your patch absolutely did work!
@EJBJane
Could you please mark your test as successfully on https://issues.joomla.org/tracker/joomla-cms/27350
("Devi specificare un valore por il campo url" = "You must specify a value of the url field")
Your find is outside of the scope of this pr and I can't reproduce it. When I test a Tagged Items page that contains the following code (similiar to your snippet; same url "/index.php" for first item) I see no errors.
<ul class="category list-striped" itemscope itemtype="http://schema.org/ItemList">
<li class="cat-list-row0 clearfix" itemprop="itemListElement" itemscope itemtype="https://schema.org/ListItem">
<h3 itemprop="name">
<a href="/index.php" itemprop="url">
00000 GHSVS Berlin Kreuzkölln
</a>
</h3>
<span class="tag-body" itemprop="description">
<p>Blah blah</p>
</span>
<meta itemprop="position" content="1">
</li>
TBH: If it wouldn't be a B\C break I would propose to remove at least the ItemList
microdata from this view ;-)
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-28 16:04:43 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
?
|
Thanks
I have tested this item
I tested this and it worked for me.
Your patch absolutely did work!
@EJBJane
Could you please mark your test as successfully on https://issues.joomla.org/tracker/joomla-cms/27350
Done! thanks
I have tested this item✅ successfully on 9c796ff
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27350.