? Pending

User tests: Successful: Unsuccessful:

avatar ReLater
ReLater
27 Dec 2019

Pull Request for Issue #27349

Summary of Changes

  • Add itemprop position to LI elements.

Testing Instructions

  • Create a tag "Joomla".
  • Add this tag to some articles.
  • Create a menu item of type "Tagged Items":

27-12-_2019_14-56-50

Actual result

  • position errors for ItemList.

27-12-_2019_15-02-19

  • Apply patch and test again

Expected result

  • No position errors.
avatar ReLater ReLater - open - 27 Dec 2019
avatar ReLater ReLater - change - 27 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Dec 2019
Category com_tags Front End
avatar ReLater ReLater - change - 27 Dec 2019
The description was changed
avatar ReLater ReLater - edited - 27 Dec 2019
avatar ChristineWk ChristineWk - test_item - 27 Dec 2019 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 27 Dec 2019

I have tested this item successfully on 9c796ff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27350.

avatar ReLater
ReLater - comment - 27 Dec 2019

If I apply this patch in the file default_items.php (at line 101) then I get another error and the original error is still there: "Duplicate values for itemListElement.url are not allowed."

@EJBJane

I can't reproduce your find with core Joomla.

  • Do you use an template override for file components/com_tags/views/tag/tmpl/default_items.php ?
    You should not for testing this pr.

  • Did you follow the testing instructions exactly? Same menu item type and so on?
    If not: What are the differences between your menu item and my screenshot above?

  • Can you provide the link to your page where I can see the error?

avatar EJBJane
EJBJane - comment - 28 Dec 2019

I did have an override.. (very embarrassing sorry)
Your patch absolutely did work!

avatar alikon
alikon - comment - 28 Dec 2019

maybe outside of the scope of this pr....
btw
i still get an error
Screenshot from 2019-12-28 10-12-16

avatar ChristineWk
ChristineWk - comment - 28 Dec 2019

@alikon
Tested yesterday after removing (temporary) my .htaccess (otherwise not possible) :-)
Just an idea: Code review shows:

<li class="cat-list-row0 clearfix" itemprop="itemListElement" itemscope itemtype="https://schema.org/ListItem"> <h3 itemprop="name"> <a href="/hstompers/index.php/testg" itemprop="url"> TestG </a> </h3>

your line is without /menue ?

<a href="/index.php/" itemprop="url">

avatar ReLater
ReLater - comment - 28 Dec 2019

Your patch absolutely did work!

@EJBJane
Could you please mark your test as successfully on https://issues.joomla.org/tracker/joomla-cms/27350

avatar ReLater
ReLater - comment - 28 Dec 2019

@alikon

("Devi specificare un valore por il campo url" = "You must specify a value of the url field")

Your find is outside of the scope of this pr and I can't reproduce it. When I test a Tagged Items page that contains the following code (similiar to your snippet; same url "/index.php" for first item) I see no errors.

<ul class="category list-striped" itemscope itemtype="http://schema.org/ItemList">
    <li class="cat-list-row0 clearfix" itemprop="itemListElement" itemscope itemtype="https://schema.org/ListItem">
	   <h3 itemprop="name">
		  <a href="/index.php" itemprop="url">
			 00000 GHSVS Berlin Kreuzkölln
		  </a>
	   </h3>
	   <span class="tag-body" itemprop="description">
	   <p>Blah blah</p>
	   </span>
	   <meta itemprop="position" content="1">
    </li>
avatar ReLater
ReLater - comment - 28 Dec 2019

TBH: If it wouldn't be a B\C break I would propose to remove at least the ItemList microdata from this view ;-)

avatar Quy Quy - change - 28 Dec 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 28 Dec 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27350.

avatar HLeithner HLeithner - close - 28 Dec 2019
avatar HLeithner HLeithner - merge - 28 Dec 2019
avatar HLeithner HLeithner - change - 28 Dec 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-12-28 16:04:43
Closed_By HLeithner
Labels Added: ?
avatar HLeithner
HLeithner - comment - 28 Dec 2019

Thanks

avatar EJBJane EJBJane - test_item - 29 Dec 2019 - Tested successfully
avatar EJBJane
EJBJane - comment - 29 Dec 2019

I have tested this item successfully on 9c796ff

I tested this and it worked for me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27350.

avatar EJBJane
EJBJane - comment - 29 Dec 2019

Your patch absolutely did work!

@EJBJane
Could you please mark your test as successfully on https://issues.joomla.org/tracker/joomla-cms/27350

Done! thanks

Add a Comment

Login with GitHub to post a comment