? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
24 Dec 2019

Pull Request for Issue #26667 .

Summary of Changes

Display tooltip on hover of sidebar icons.

Testing Instructions

Login to backend.
Click on toggle menu.
Hover over an icon.
No tooltip.
Apply PR.
Hover over an to display tooltip.

avatar Quy Quy - open - 24 Dec 2019
avatar Quy Quy - change - 24 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Dec 2019
Category Modules Administration Templates (admin)
avatar infograf768
infograf768 - comment - 25 Dec 2019

Works fine

Note: that sort of tooltip is formatted by the OS and browser and using such a small font size that it is hard to read.
The problem is not limited to this tooltip but all over J. Maybe it is possible, in another PR, to increase the size with a specific js?

avatar infograf768 infograf768 - test_item - 25 Dec 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 25 Dec 2019

I have tested this item successfully on 2e0cb63


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27347.

avatar brianteeman
brianteeman - comment - 25 Dec 2019

Maybe it is possible, in another PR, to increase the size

No its a native browser setting and we should not change those.

I personally would prefer something more "styled" than just using the title tag.
menu

avatar ChristineWk
ChristineWk - comment - 26 Dec 2019

In principle it works, I see the tooltips. But the title shows:
<a id="menu-collapse" href="#" class=""> <span id="menu-collapse-icon" class="fa fa-fw fa-toggle-on" aria-hidden="true" title="JTOGGLE_SIDEBAR_MENU"></span> <span class="sidebar-item-title">JTOGGLE_SIDEBAR_MENU</span> </a><hr />This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27347.

avatar infograf768
infograf768 - comment - 26 Dec 2019

@ChristineWk
it is translated here.

avatar ChristineWk
ChristineWk - comment - 26 Dec 2019

Aha :-) ... Is it successful now? - even I see above title: JTOGGLE_SIDEBAR_MENU

avatar ChristineWk ChristineWk - test_item - 26 Dec 2019 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 26 Dec 2019

I have tested this item successfully on 2e0cb63

The reason of wrong translation was: I hv beta-dev from october, but there is: 4e7bc1c.
Finally I changed all above files accordingly.
<a id="menu-collapse" href="#" class=""> <span id="menu-collapse-icon" class="fa fa-fw fa-toggle-on" aria-hidden="true" title="Toggle Menu"></span> <span class="sidebar-item-title">Toggle Menu</span> </a>


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27347.
avatar infograf768 infograf768 - change - 27 Dec 2019
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 27 Dec 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27347.

avatar infograf768
infograf768 - comment - 27 Dec 2019

@brianteeman
I see no way to modify admin-menu.js (and metismenu) to get what you propose.
As far as I understand, you propose https://mm.onokumus.com/mm-vertical-hover.html which is very different from what we use today, as it is unrelated to our menu toggle.
If you do not propose some code shortly, I suggest we merge this.

avatar brianteeman
brianteeman - comment - 27 Dec 2019

@infograf768 no need to touch any js at all see #27352

avatar richard67
richard67 - comment - 27 Dec 2019

Both PR's work for me, this one here and @brianteeman 's #27352 . Not sure what's the better way to do it regarding all aspects, but from a visual point of view I really like Brian's solution. It really is nice.

avatar Quy
Quy - comment - 27 Dec 2019

Closing in favour of #27352

avatar Quy Quy - change - 27 Dec 2019
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2019-12-27 18:36:59
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 27 Dec 2019

Add a Comment

Login with GitHub to post a comment