? ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
23 Dec 2019

Pull Request for Issue #27236

Summary of Changes

When a Content Language is trashed or deleted

  1. Corrected Notice in com_associations Manager
  2. Displaying a Warning in each Manager concerned
  3. Do not display the concerned associated item in the associations column

Testing Instructions

Install a multingual site with 3 or more languages using the multilingual sample data.
Trash or delete one of the Content Languages.
Display managers:
articles, categories, menus, contacts, newsfeeds (for contacts and newsfeeds make sure you have associated items including some tagged to the trashed Content Language)
Display Associations component manager after selecting a Type and a Language

-->Screenshots below are captured when the fa-IR content language is trashed.

Before patch

In managers:
Associated Items tagged to the trashed/deleted Content Language do display.
In Associations component:
We get a Notice. Notice: Undefined index: link in \layouts\joomla\content\associations.php on line 18

After patch

No more Notice.
Associated items which content language is trashed/deleted do not display in the associations column
A Warning is displayed informing the user about the issue.

Screen Shot 2019-12-23 at 09 56 00

Screen Shot 2019-12-23 at 10 09 32

@Quy @Fedik

Note: PR for the other issue ( LanguageHelper::getContentLanguages) discussed in #27236 is done separately.

avatar infograf768 infograf768 - open - 23 Dec 2019
avatar infograf768 infograf768 - change - 23 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Dec 2019
Category Administration com_associations com_categories com_contact com_content com_menus com_newsfeeds Language & Strings Layout
e67ad3c 23 Dec 2019 avatar infograf768 cs
avatar infograf768 infograf768 - change - 23 Dec 2019
Labels Added: ? ?
avatar Fedik Fedik - test_item - 23 Dec 2019 - Tested successfully
avatar Fedik
Fedik - comment - 23 Dec 2019

I have tested this item successfully on e67ad3c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27340.

avatar Quy Quy - test_item - 23 Dec 2019 - Tested successfully
avatar Quy
Quy - comment - 23 Dec 2019

I have tested this item successfully on e67ad3c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27340.

avatar Quy Quy - change - 23 Dec 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 23 Dec 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27340.

avatar infograf768 infograf768 - change - 23 Dec 2019
Labels Added: ?
avatar HLeithner HLeithner - change - 27 Dec 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-12-27 10:08:39
Closed_By HLeithner
avatar HLeithner HLeithner - close - 27 Dec 2019
avatar HLeithner HLeithner - merge - 27 Dec 2019
avatar HLeithner
HLeithner - comment - 27 Dec 2019

Thanks

Add a Comment

Login with GitHub to post a comment